Bug 315365 - Alpha Channel with Curves [Feature Request]
Summary: Alpha Channel with Curves [Feature Request]
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filters (show other bugs)
Version: unspecified
Platform: Other All
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL: http://rutube.ru/video/e94cfd56b54b73...
Keywords:
: 285123 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-02-18 09:41 UTC by Paul Geraskin
Modified: 2013-05-17 07:15 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Alpha Curve Feature implemented. (7.00 KB, patch)
2013-04-24 18:21 UTC, Sahil
Details
Removing unnecessary lines (3.14 KB, patch)
2013-04-26 18:29 UTC, Sahil
Details
Alpha Curve Optimization (4.24 KB, patch)
2013-04-26 18:30 UTC, Sahil
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Geraskin 2013-02-18 09:41:27 UTC
According to talk to Boud and forum dicussion:
http://forum.kde.org/viewtopic.php?f=137&t=109790

This is feature request for Krita.

How it works in Gimp:
http://rutube.ru/video/e94cfd56b54b7354c563b434a5f97a3d/

Reproducible: Always
Comment 1 Paul Geraskin 2013-03-31 09:10:12 UTC
Added video to vimeo too. https://vimeo.com/53000750
Comment 2 Halla Rempt 2013-03-31 09:13:10 UTC
I wonder whether we couldn't create a fake lcms colorspace with four color channels, red, green, blue, gray or something and use that to make lcms not disregard the alpha channel.
Comment 3 Sahil 2013-04-24 18:21:21 UTC
Created attachment 79421 [details]
Alpha Curve Feature implemented.

also removed unused channel type enums.
Comment 4 Halla Rempt 2013-04-26 11:45:27 UTC
*** Bug 285123 has been marked as a duplicate of this bug. ***
Comment 5 Sahil 2013-04-26 18:29:55 UTC
Created attachment 79476 [details]
Removing unnecessary lines
Comment 6 Sahil 2013-04-26 18:30:49 UTC
Created attachment 79477 [details]
Alpha Curve Optimization
Comment 7 Halla Rempt 2013-04-28 20:12:47 UTC
Git commit 974dabcaf1e3c41d7ab3d7cc9d10c36d17a7a78b by Boudewijn Rempt.
Committed on 28/04/2013 at 21:43.
Pushed by rempt into branch 'master'.

Implement support for the alpha channel in the curves filter.
Patch by Sahil Nagpal (<nagpal.sahil01@gmail.com>)

M  +7    -7    krita/plugins/filters/colorsfilters/kis_perchannel_filter.cpp
M  +0    -2    krita/plugins/paintops/libpaintop/kis_auto_brush_widget.h
M  +2    -2    libs/pigment/KoChannelInfo.h
M  +40   -10   plugins/colorengines/lcms2/LcmsColorSpace.h

http://commits.kde.org/calligra/974dabcaf1e3c41d7ab3d7cc9d10c36d17a7a78b
Comment 8 Paul Geraskin 2013-04-29 15:52:28 UTC
Thank you guys! 
It works perfectly.
Video test: https://vimeo.com/65009373
Comment 9 Siddharth 2013-05-17 07:15:25 UTC
Git commit 6c979f2b6c967bddb3a5564eb6f92de070d49a31 by Siddharth Sharma, on behalf of Boudewijn Rempt.
Committed on 28/04/2013 at 21:43.
Pushed by siddharthsharma into branch 'krita-psd-plugin-siddharth'.

Implement support for the alpha channel in the curves filter.
Patch by Sahil Nagpal (<nagpal.sahil01@gmail.com>)

M  +7    -7    krita/plugins/filters/colorsfilters/kis_perchannel_filter.cpp
M  +0    -2    krita/plugins/paintops/libpaintop/kis_auto_brush_widget.h
M  +2    -2    libs/pigment/KoChannelInfo.h
M  +40   -10   plugins/colorengines/lcms2/LcmsColorSpace.h

http://commits.kde.org/calligra/6c979f2b6c967bddb3a5564eb6f92de070d49a31