Bug 314818 - Script error: Could not parse 'VmFlags: mr mw me ac'
Summary: Script error: Could not parse 'VmFlags: mr mw me ac'
Status: RESOLVED FIXED
Alias: None
Product: ksysguard
Classification: Unmaintained
Component: ksysguard (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-10 11:11 UTC by Kevin Funk
Modified: 2013-03-10 10:18 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.10.2
Sentry Crash Report:


Attachments
Patch to fix the issue (1.03 KB, patch)
2013-03-09 21:31 UTC, Ralf Jung
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Funk 2013-02-10 11:11:13 UTC
Showing the detailled process info of any process yields the above error.

This worked fine in 4.9.x, afaik.

Reproducible: Always
Comment 1 Kevin Funk 2013-02-10 11:19:55 UTC
Well, the above comment about ksysguard working fine in 4.9.x is of course wrong.

The smaps output changed a bit, so the reason is of course the more recent kernel.
See http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=log;h=834f82e2aa9a8ede94b17b656329f850c1471514.

Maybe it is better to just ignore unknown fields instead of throwing errors?
Comment 2 Ralf Jung 2013-03-09 21:31:17 UTC
Created attachment 77894 [details]
Patch to fix the issue

Attached is a patch to fix the issue.
Comment 3 Hrvoje Senjan 2013-03-09 22:49:35 UTC
Confirming that the patch resolves the problem :-)
Comment 4 John Tapsell 2013-03-09 23:46:25 UTC
For future-proofing, it seems better to not throw an error at all for
unknown matches.
Comment 5 Ralf Jung 2013-03-10 09:56:18 UTC
I opened review request https://git.reviewboard.kde.org/r/109385/ for this to find someone giving me the okay to push this ;-)

(In reply to comment #4)
> For future-proofing, it seems better to not throw an error at all for
> unknown matches.
The intend of the original code was obviously to deal explicitly with all lines in that file. I did not want to change that intend, but if the maintainer tells me this is okay with him, I sure can do that.
Comment 6 John Tapsell 2013-03-10 10:04:16 UTC
Yep, it's okay by me, thanks :-)
Comment 7 Ralf Jung 2013-03-10 10:09:43 UTC
Oh, you *are* the maintainer... sorry, I did not know that ;-)
Then I'll change it to ignore unknown lines,a dn push to stable and master.
Comment 8 Ralf Jung 2013-03-10 10:15:46 UTC
Git commit ecd6271126e7579390183f188d263722381be86a by Ralf Jung.
Committed on 10/03/2013 at 11:12.
Pushed by ralfjung into branch 'master'.

Fix parse error in advanced memroy information for 3.8 kernels

REVIEW: 109385
FIXED-IN: 4.10.2

M  +1    -2    libs/ksysguard/scripts/smaps/main.js

http://commits.kde.org/kde-workspace/ecd6271126e7579390183f188d263722381be86a
Comment 9 John Tapsell 2013-03-10 10:16:20 UTC
That would be great, thank you :-)
Comment 10 Ralf Jung 2013-03-10 10:18:18 UTC
Git commit f41d5f969b94d3bafea56f9fcfc7db5e5d1e3f5f by Ralf Jung.
Committed on 10/03/2013 at 11:12.
Pushed by ralfjung into branch 'KDE/4.10'.

Fix parse error in advanced memroy information for 3.8 kernels

REVIEW: 109385
FIXED-IN: 4.10.2

M  +1    -2    libs/ksysguard/scripts/smaps/main.js

http://commits.kde.org/kde-workspace/f41d5f969b94d3bafea56f9fcfc7db5e5d1e3f5f