Bug 314482 - [Patch] loading of gpx files does not work
Summary: [Patch] loading of gpx files does not work
Status: RESOLVED WORKSFORME
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: 1.5 (KDE 4.10)
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: marble-bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-05 22:21 UTC by Roman K.
Modified: 2023-02-01 05:04 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
allow parsing for gpx-files without namespace declaration (847 bytes, patch)
2013-02-11 22:39 UTC, Roman K.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman K. 2013-02-05 22:21:56 UTC
When I try to load a *.gpx file in marble, it doesn't get displayed. Displaying the file with other programs works. *.kml files can be displayed in marble.

Reproducible: Always

Steps to Reproduce:
1. click on open
2. select *.gpx-file

Actual Results:  
marble does not display it

Expected Results:  
marble should display the file on the map
Comment 1 Roman K. 2013-02-10 22:20:45 UTC
Ok, I looked into this. The *.gpx files I tried cannot be loaded because they lack a namespace declaration (something like xmlns="http://www.topografix.com/GPX/1/1"). However, the GpxPlugin (class GpxParser) only succeeds if a namespace is specified (even if it is ignored afterwards).

We could add a check if the namespace is empty and if so, continue processing. 

If this is not intended, we could at least inform the user that their files could not be parsed correctly. At the moment just nothing happens.
Comment 2 Dennis Nienhüser 2013-02-11 07:16:31 UTC
Sounds good to me: Continue processing with a default namespace (or guess one), but add a warning (mDebug) in that case.
Comment 3 Roman K. 2013-02-11 22:39:45 UTC
Created attachment 77175 [details]
allow parsing for gpx-files without namespace declaration

This is the first time that I propose a patch, I'm not really sure if this the right way to do it.
Comment 4 Dennis Nienhüser 2013-02-12 07:40:14 UTC
Looks good. Just wondering if we need to take additional care that the file extension is right (Marble used to feed any file to any parser, so the gpx parser got kml files as well. This would lead to a problem here since both are xml. Afaik this does not happen anymore and the patch is fine as is).
Comment 5 Roman K. 2013-02-12 22:28:13 UTC
In MarbleRunnerManager::parseFile() the file extensions for the plugins are checked. The GPX-Plugin specifies "gpx" as extension, so it should be fine.

If the plugin does not specify any file-extensions (the list with the extensions is empty), parsing is started for all files, but changes to the gpx-plugin doesn't change anything here.
Comment 6 Andrew Crouthamel 2018-11-09 01:04:12 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Andrew Crouthamel 2018-11-20 04:11:21 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 8 Justin Zobel 2023-01-02 02:04:34 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 9 Bug Janitor Service 2023-01-17 05:15:16 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 10 Bug Janitor Service 2023-02-01 05:04:49 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!