Bug 313495 - [combo boxes] manual keyboard entry of a value ( click+shift ) broken
Summary: [combo boxes] manual keyboard entry of a value ( click+shift ) broken
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-19 11:46 UTC by David REVOY
Modified: 2013-01-21 20:17 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2013-01-19 11:46:28 UTC
Manual keyboard entry of a value ( click+shift ) is broken

scenario :
1) Sometime ( it's rare but happen ) , I want to enter a value in the combo box ; (for ex, 42 in the 'Size' one  on the toolbar ). 
2) As a Blender old reflex , I press Shift, and click on the middle text of the combo-box
3) The combo box react as expected and offer a cursor, underline the number to let me edit the value

problem :
4) If I press 'enter' to confirm , the value return to the previous one
So, I can't set the value to 42 this way 

Expected :
Confirm with enter, and get the combo box slider to switch to 42 and use a 42 brush sized. 
( this affect all combo-box, annoying for fine-tuning in brush setting )
Comment 1 Sven Langkamp 2013-01-21 15:28:16 UTC
Confirmed. Manually entering values is broke. The widget doesn't get the event to the enter press.
Comment 2 Sven Langkamp 2013-01-21 20:17:57 UTC
Git commit 7f9879631ad8f5310d44be76f364a0ec9adea87d by Sven Langkamp.
Committed on 21/01/2013 at 21:15.
Pushed by langkamp into branch 'master'.

workaround for the focus lost, since the slot is called when the editing is finished or we lost focus we need to check if we really lost focus before hiding the edit

M  +5    -1    krita/ui/widgets/kis_slider_spin_box.cpp

http://commits.kde.org/calligra/7f9879631ad8f5310d44be76f364a0ec9adea87d