Bug 313228 - Checkboxes with bad usability in System settings -> Window behavior -> Moving
Summary: Checkboxes with bad usability in System settings -> Window behavior -> Moving
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: 4.9.98 (RC3)
Platform: Gentoo Packages Linux
: NOR minor
Target Milestone: 4.10
Assignee: KWin default assignee
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2013-01-14 11:06 UTC by Marco Poletti
Modified: 2013-01-23 21:12 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Poletti 2013-01-14 11:06:55 UTC
In System settings -> Window behavior -> Moving, the checkboxes have associated text, but when clicking such text the checkbox is only focused, and not toggled as it should be. The checkboxes in the other tabs work as expected.
I think that the checkboxes' text has been placed in a separate label instead of setting it in the checkbox widget.

Btw, thanks for adding the "Display borders on maximized windows" checkbox! I have been manually changing the config files to add it before KDE 4.10, and had to be careful not to use the system settings because it would have removed my setting.

Reproducible: Always

Steps to Reproduce:
1. Open System settings -> Window behavior -> Moving
2. Click on the text on the side of one of the three checkboxes

Actual Results:  
The checkbox is just focused

Expected Results:  
The checkbox is toggled
Comment 1 Thomas Lübking 2013-01-14 12:05:07 UTC
Needs a focus buddy.

(In reply to comment #1)
> Btw, thanks for adding the "Display borders on maximized windows" checkbox!

That's probably not what you think it is. It is NOT

BorderlessMaximizedWindows
but
MoveResizeMaximizedWindows
Comment 2 Marco Poletti 2013-01-14 14:50:57 UTC
(In reply to comment #1)
> [...]
> That's probably not what you think it is. It is NOT
> 
> BorderlessMaximizedWindows
> but
> MoveResizeMaximizedWindows

You're right. I've now filed that as bug 313244.
Comment 3 Thomas Lübking 2013-01-23 17:14:41 UTC
I've  a patch in the pipeline and gonna push it tonight, don't worry ;-)
Comment 4 Thomas Lübking 2013-01-23 21:11:34 UTC
Git commit 2f95e0766b2938c097878521f5ebaf14fae1359a by Thomas Lübking.
Committed on 16/01/2013 at 14:21.
Pushed by luebking into branch 'KDE/4.10'.

turn labels into checkboxes

M  +60   -51   kwin/kcmkwin/kwinoptions/moving.ui

http://commits.kde.org/kde-workspace/2f95e0766b2938c097878521f5ebaf14fae1359a
Comment 5 Thomas Lübking 2013-01-23 21:12:24 UTC
Git commit 027c6311ba5bceba23d4197be8f89cd456e750b1 by Thomas Lübking.
Committed on 16/01/2013 at 14:21.
Pushed by luebking into branch 'master'.

turn labels into checkboxes

M  +60   -51   kwin/kcmkwin/kwinoptions/moving.ui

http://commits.kde.org/kde-workspace/027c6311ba5bceba23d4197be8f89cd456e750b1