Bug 310883 - Wrong hover for Duplicate Custom Templates
Summary: Wrong hover for Duplicate Custom Templates
Status: RESOLVED FIXED
Alias: None
Product: kmail2
Classification: Applications
Component: config dialog (show other bugs)
Version: 4.10 pre
Platform: Ubuntu Linux
: NOR minor
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2012-11-29 16:59 UTC by Bernd Oliver Sünderhauf
Modified: 2012-11-30 10:25 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.10


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Oliver Sünderhauf 2012-11-29 16:59:47 UTC
In Composer->Custom Templates, when hovering the Duplicate button, it says:
"Remove the selected custom template" where it should say something like:
"Duplicate the selected custom template"

Reproducible: Always
Comment 1 Laurent Montel 2012-11-29 17:17:43 UTC
Git commit 3f80fef6234b5c37a981049f324f74413f31be22 by Montel Laurent.
Committed on 29/11/2012 at 18:17.
Pushed by mlaurent into branch 'master'.

Fix Bug 310883 - Wrong hover for Duplicate Custom Templates

FIXED-IN: 4.10

M  +2    -2    templateparser/ui/customtemplates_base.ui

http://commits.kde.org/kdepim/3f80fef6234b5c37a981049f324f74413f31be22
Comment 2 Bernd Oliver Sünderhauf 2012-11-30 10:11:46 UTC
Thought this would be a nice Junior Job, but obviously there are so few people that do coding, that you need to do it or noone does...

Anyway, I think the "What's this" explanations are quite unnecessary on these very intuitive buttons - in the end they only replicate the tooltip text. This might make some sense if your plans are to really have them /everywhere/, but otherwise they're just adding more codelines. What do you think?
Comment 3 Laurent Montel 2012-11-30 10:25:02 UTC
(In reply to comment #2)
> Thought this would be a nice Junior Job, but obviously there are so few
> people that do coding, that you need to do it or noone does...

Yes. And it's new i18n which I added in 4.9.x so 6 months ago. It's not a good idea to wait 4.11 :)

> Anyway, I think the "What's this" explanations are quite unnecessary on
> these very intuitive buttons - in the end they only replicate the tooltip
> text. This might make some sense if your plans are to really have them
> /everywhere/, but otherwise they're just adding more codelines. What do you
> think?

It's right not really useful, but as translator already translated them I will not remove it.
But it's right what'sthis is useful for a lot of other widgets.
We need to add them.
(but I am not a good english man, so I can't add them).