Bug 309724 - [JJ] GHNS button displays icon, even if disabled in style settings
Summary: [JJ] GHNS button displays icon, even if disabled in style settings
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: compositing (show other bugs)
Version: git master
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: 4.11
Assignee: KWin default assignee
URL: https://git.reviewboard.kde.org/r/108...
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2012-11-08 01:16 UTC by Christoph Feck
Modified: 2013-01-10 07:28 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 4.11
mgraesslin: ReviewRequest+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2012-11-08 01:16:51 UTC
The "Get new effects" button displays the "Star" icon, even if icons are disabled in style settings. To make it respect that setting, you need to use KPushButton, instead of QPushButton. Or, even better, use the special button in libknewstuff3.
Comment 1 Christoph Feck 2012-11-08 01:19:08 UTC
Additionally, the button text should be "Get New Effects ...", not "Get New Effect" to make it consistent with the rest of KDE.
Comment 2 Christoph Feck 2012-11-08 01:26:45 UTC
On the other hand, there is only one effect to get, so the button is right.

(SCNR)
Comment 3 Thomas Lübking 2012-11-08 01:43:04 UTC
While at it: the button should probably in line with the search

______________________________ ======
-------------------------------------------------
|                                                           |
|                                                           |
|                                                           |
-------------------------------------------------
=== ===                                     ===
Comment 4 Martin Flöser 2013-01-10 07:28:57 UTC
Git commit 366ea1e7e76f75e82209ebf412a265553451cfa0 by Martin Gräßlin.
Committed on 09/01/2013 at 08:30.
Pushed by graesslin into branch 'master'.

Use KPushButton for GHNS in Effects KCM

Also rename to proper name "Get New Effects ...".
FIXED-IN: 4.11
REVIEW: 108286

M  +8    -3    kwin/kcmkwin/kwincompositing/main.ui

http://commits.kde.org/kde-workspace/366ea1e7e76f75e82209ebf412a265553451cfa0