Bug 309428 - please (let the user) increase the row height of kiriki
Summary: please (let the user) increase the row height of kiriki
Status: RESOLVED FIXED
Alias: None
Product: kiriki
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Albert Astals Cid
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2012-11-02 15:02 UTC by Janet
Modified: 2013-02-10 22:21 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.11.0


Attachments
Option to set the table's row height (7.14 KB, patch)
2013-01-26 14:11 UTC, Ian Simpson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Janet 2012-11-02 15:02:56 UTC
Thanks for adding the font size option (Bug 225582). It makes the situation better. But alas inscreasing the font size doesn't make the rows much higher, so it still isn't that easy to hit the right field. 

Could you please also allow to user to make the rows higher - or add more space between them? E.g. optimal for me would be font size 14-16 with the row height of font size 20.

Reproducible: Always
Comment 1 Ian Simpson 2013-01-26 14:11:24 UTC
Created attachment 76736 [details]
Option to set the table's row height

I had a go at this after searching through the junior jobs.

Seems a very useful option to have as the rows are somewhat cramped at the moment.

I didn't override the paint method at first, but all the cells were being drawn with a gradient which I didn't think looked as nice as the plain colours.
Comment 2 Albert Astals Cid 2013-01-26 16:01:44 UTC
Hi Ian, thanks for the contribution :-)

Can you please use reviewboard for the patch? It's so much easier to review there. As a first note, the spacing is totally broken regarding the style used in the rest of the file, please fix that first.
Comment 3 Albert Astals Cid 2013-02-10 22:21:52 UTC
Git commit e457c3c4b5f745068f48b8a347877b43ae132835 by Albert Astals Cid, on behalf of Ian Simpson.
Committed on 10/02/2013 at 23:21.
Pushed by aacid into branch 'master'.

Add an option to change the row height

REVIEW: 108606
FIXED-IN: 4.11.0

M  +1    -0    src/CMakeLists.txt
M  +21   -0    src/configPage.ui
M  +6    -0    src/configwidget.cpp
M  +1    -0    src/configwidget.h
A  +42   -0    src/itemdelegate.cpp     [License: GPL (v2+)]
C  +16   -13   src/itemdelegate.h [from: src/configwidget.h - 056% similarity]
M  +17   -1    src/kiriki.cpp
M  +3    -0    src/kiriki.h
M  +4    -0    src/kiriki.kcfg

http://commits.kde.org/kiriki/e457c3c4b5f745068f48b8a347877b43ae132835