Bug 309388 - A reproducible crash in configuring window decoration
Summary: A reproducible crash in configuring window decoration
Status: RESOLVED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: win deco (show other bugs)
Version: 4.9
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-01 17:19 UTC by ono
Modified: 2012-11-01 21:07 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.3


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ono 2012-11-01 17:19:49 UTC
A reproducible crash in configuring window decoration. Following are steps.

Reproducible: Always

Steps to Reproduce:
1. Open "System Settings" > "Workspace Appearance" > "Window Decoration."
2. Click the button "Configure Decoration" and select the tab "Window-Specific Overrides"
3. "Add" > "OK" > "Delete" > "OK" > "Edit"
4. Crash.
Actual Results:  
The whole System Settings exit automatically and Pop-up KDE bug reporter.

Expected Results:  
No crash or the "edit" button should be inactive.
Comment 1 Martin Flöser 2012-11-01 17:40:26 UTC
please attach the backtrace which can be retrieved from the advanced tab of the KDE bug reporter.
Comment 2 Hugo Pereira Da Costa 2012-11-01 17:54:28 UTC
No need.
Can reproduce :)
Comment 3 Hugo Pereira Da Costa 2012-11-01 18:11:38 UTC
Git commit ba80606b1e0b6f09b69344a514b595404fc82f33 by Hugo Pereira Da Costa.
Committed on 01/11/2012 at 19:09.
Pushed by hpereiradacosta into branch 'KDE/4.9'.

oxygenlistmodel: Added "contains" method to generic model, to check index validity better.
oxygenexceptionlistwidget: better check index validity in "edit" method. Also update buttons status after removing items, since
apparently selectionChanged signal is not sent by Qt.

M  +3    -2    kwin/clients/oxygen/config/oxygenexceptionlistwidget.cpp
M  +88   -84   libs/oxygen/oxygenlistmodel.h

http://commits.kde.org/kde-workspace/ba80606b1e0b6f09b69344a514b595404fc82f33
Comment 4 Hugo Pereira Da Costa 2012-11-01 18:14:38 UTC
Git commit 5a98ab9f037fa1b6b84faada899d0932a4944f89 by Hugo Pereira Da Costa.
Committed on 01/11/2012 at 19:09.
Pushed by hpereiradacosta into branch 'master'.

oxygenlistmodel: Added "contains" method to generic model, to check index validity better.
oxygenexceptionlistwidget: better check index validity in "edit" method. Also update buttons status after removing items, since
apparently selectionChanged signal is not sent by Qt.

M  +3    -2    kwin/clients/oxygen/config/oxygenexceptionlistwidget.cpp
M  +88   -84   libs/oxygen/oxygenlistmodel.h

http://commits.kde.org/kde-workspace/5a98ab9f037fa1b6b84faada899d0932a4944f89
Comment 5 Hugo Pereira Da Costa 2012-11-01 18:15:31 UTC
That fixes it. (in fact twice):
1/ edit button is properly disabled after "remove"
2/ even if it where not, the check on the item to be edited is more robust now. 

Thanks for reporting,

Hugo