Bug 309099 - Crash on creating an Adjustment Layer with Blur filter
Summary: Crash on creating an Adjustment Layer with Blur filter
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filters (show other bugs)
Version: git master (please specify the git hash!)
Platform: unspecified Linux
: NOR crash
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
: 308937 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-10-27 14:19 UTC by Dmitry Kazakov
Modified: 2012-11-13 04:30 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/calligra/5620b92e2a7380210fa7dae85ad16cfdc7499aea
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Kazakov 2012-10-27 14:19:26 UTC 
The crash happens because the filter configuration dialog resets the filter configuration every time when a value in a form changes. At the same time updating threads can access this configuration.
Comment 1 Dmitry Kazakov 2012-10-27 14:25:18 UTC 
*** Bug 308937 has been marked as a duplicate of this bug. ***
Comment 2 Dmitry Kazakov 2012-11-01 17:46:33 UTC 
Git commit 629e86ed064b96b514e1d0d1a95cf30a001fc09d by Dmitry Kazakov.
Committed on 01/11/2012 at 18:39.
Pushed by dkazakov into branch 'master'.

Fixed a bug in storing the filter configuration in filter-based layers

The storage of the filter configuration in now implemented in
KisNodeFilterInterface and is done by means of external shared pointers
(QSharedPointer). This makes the use of this configuration thread safe.

This patch also fixes various memory leaks in
KisLayerManager and KisMaskManager.

M  +1    -0    krita/image/CMakeLists.txt
M  +51   -19   krita/image/commands/kis_change_filter_command.h
D  +0    -66   krita/image/commands/kis_change_generator_command.h
M  +0    -1    krita/image/commands/kis_node_commands.h
M  +15   -30   krita/image/generator/kis_generator_layer.cpp
M  +2    -18   krita/image/generator/kis_generator_layer.h
M  +23   -37   krita/image/kis_adjustment_layer.cc
M  +1    -13   krita/image/kis_adjustment_layer.h
M  +2    -2    krita/image/kis_async_merger.cpp
M  +22   -42   krita/image/kis_filter_mask.cpp
M  +1    -7    krita/image/kis_filter_mask.h
A  +54   -0    krita/image/kis_node_filter_interface.cpp     [License: GPL (v2+)]
M  +26   -6    krita/image/kis_node_filter_interface.h
M  +5    -2    krita/image/kis_selection_based_layer.cpp
M  +2    -1    krita/image/kis_selection_based_layer.h
M  +44   -33   krita/ui/kis_layer_manager.cc
M  +34   -25   krita/ui/kis_mask_manager.cc
M  +3    -3    krita/ui/kra/kis_kra_load_visitor.cpp
M  +8    -7    krita/ui/kra/kis_kra_save_visitor.cpp
M  +2    -2    krita/ui/kra/kis_kra_savexml_visitor.cpp

http://commits.kde.org/calligra/629e86ed064b96b514e1d0d1a95cf30a001fc09d
Comment 3 Dmitry Kazakov 2012-11-13 04:30:08 UTC 
Git commit 5620b92e2a7380210fa7dae85ad16cfdc7499aea by Dmitry Kazakov.
Committed on 01/11/2012 at 18:39.
Pushed by dkazakov into branch 'calligra/2.6'.

Fixed a bug in storing the filter configuration in filter-based layers

The storage of the filter configuration in now implemented in
KisNodeFilterInterface and is done by means of external shared pointers
(QSharedPointer). This makes the use of this configuration thread safe.

This patch also fixes various memory leaks in
KisLayerManager and KisMaskManager.

M  +1    -0    krita/image/CMakeLists.txt
M  +51   -19   krita/image/commands/kis_change_filter_command.h
D  +0    -66   krita/image/commands/kis_change_generator_command.h
M  +0    -1    krita/image/commands/kis_node_commands.h
M  +15   -30   krita/image/generator/kis_generator_layer.cpp
M  +2    -18   krita/image/generator/kis_generator_layer.h
M  +23   -37   krita/image/kis_adjustment_layer.cc
M  +1    -13   krita/image/kis_adjustment_layer.h
M  +2    -2    krita/image/kis_async_merger.cpp
M  +22   -42   krita/image/kis_filter_mask.cpp
M  +1    -7    krita/image/kis_filter_mask.h
A  +54   -0    krita/image/kis_node_filter_interface.cpp     [License: GPL (v2+)]
M  +26   -6    krita/image/kis_node_filter_interface.h
M  +5    -2    krita/image/kis_selection_based_layer.cpp
M  +2    -1    krita/image/kis_selection_based_layer.h
M  +44   -33   krita/ui/kis_layer_manager.cc
M  +34   -25   krita/ui/kis_mask_manager.cc
M  +3    -3    krita/ui/kra/kis_kra_load_visitor.cpp
M  +8    -7    krita/ui/kra/kis_kra_save_visitor.cpp
M  +2    -2    krita/ui/kra/kis_kra_savexml_visitor.cpp

http://commits.kde.org/calligra/5620b92e2a7380210fa7dae85ad16cfdc7499aea