Bug 308875 - Moving layers up and down causes crash
Summary: Moving layers up and down causes crash
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Krita Sketch (show other bugs)
Version: git master (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-23 14:05 UTC by Halla Rempt
Modified: 2013-07-09 10:02 UTC (History)
0 users

See Also:
Latest Commit: http://commits.kde.org/calligra/902f55a915fa8e851f8e5c37e6c5f1e9b7976673
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Halla Rempt 2012-10-23 14:05:17 UTC 
Sketch crashes if you move layers up and down.
Comment 1 Halla Rempt 2012-10-23 14:28:01 UTC 
Thread 1 (Thread 0x7f71286b7780 (LWP 26671)):
[KCrash Handler]
#5  0x00007f7125a2c0f4 in KoShape::parent (this=0x6239ce0) at /home/boud/kde/src/sketch/libs/flake/KoShape.cpp:1112
#6  0x00007f71275c86c0 in KisNodeShape::checkIfDescendant (this=0x6239ce0, this@entry=0x6b28810, activeLayer=activeLayer@entry=0x6239ce0) at /home/boud/kde/src/sketch/krita/ui/flake/kis_node_shape.cpp:82
#7  0x00007f71275c87b6 in KisNodeShape::editabilityChanged (this=this@entry=0x6b28810) at /home/boud/kde/src/sketch/krita/ui/flake/kis_node_shape.cpp:107
#8  0x00007f71275c9065 in KisNodeShape::KisNodeShape (this=0x6b28810, node=...) at /home/boud/kde/src/sketch/krita/ui/flake/kis_node_shape.cpp:57
#9  0x00007f71275c761c in KisNodeShapesGraph::addNode (this=0x3342710, node=..., parent=..., aboveThis=...) at /home/boud/kde/src/sketch/krita/ui/flake/kis_node_shapes_graph.cpp:40
#10 0x00007f71275caa40 in KisShapeController::addNodeImpl (this=0x27635a0, node=..., parent=..., aboveThis=...) at /home/boud/kde/src/sketch/krita/ui/flake/kis_shape_controller.cpp:91
#11 0x00007f71275bd922 in KisDummiesFacadeBase::slotContinueAddNode (this=0x27635a0, node=..., parent=..., aboveThis=...) at /home/boud/kde/src/sketch/krita/ui/flake/kis_dummies_facade_base.cpp:144
#12 0x00007f7127561f45 in KisDummiesFacadeBase::qt_static_metacall (_o=0x27635a0, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at /home/boud/kde/build/sketch/krita/ui/moc_kis_dummies_facade_base.cpp:92
#13 0x00007f712052f39f in QMetaObject::activate (sender=0x27635a0, m=<optimized out>, local_signal_index=<optimized out>, argv=0x7fff83fa3160) at kernel/qobject.cpp:3556
#14 0x00007f712755fe1c in KisDummiesFacadeBase::sigContinueAddNode (this=<optimized out>, _t1=..., _t2=..., _t3=...) at /home/boud/kde/build/sketch/krita/ui/moc_kis_dummies_facade_base.cpp:142
#15 0x00007f71275c038a in KisDummiesFacadeBase::slotNodeAdded (this=0x27635a0, node=...) at /home/boud/kde/src/sketch/krita/ui/flake/kis_dummies_facade_base.cpp:115
#16 0x00007f71275622a1 in KisDummiesFacadeBase::qt_static_metacall (_o=0x27635a0, _c=<optimized out>, _id=<optimized out>, _a=0x7fff83fa35a0) at /home/boud/kde/build/sketch/krita/ui/moc_kis_dummies_facade_base.cpp:90
#17 0x00007f712052f39f in QMetaObject::activate (sender=0x3376ea0, m=<optimized out>, local_signal_index=<optimized out>, argv=0x7fff83fa35a0) at kernel/qobject.cpp:3556
#18 0x00007f71268577f5 in KisImage::sigNodeAddedAsync (this=this@entry=0x3376ea0, _t1=...) at /home/boud/kde/build/sketch/krita/image/kis_image.moc:258
#19 0x00007f712685ab92 in KisImage::qt_static_metacall (_o=0x3376ea0, _c=<optimized out>, _id=<optimized out>, _a=0x7fff83fa3740) at /home/boud/kde/build/sketch/krita/image/kis_image.moc:117
#20 0x00007f712052f39f in QMetaObject::activate (sender=0x335f180, m=<optimized out>, local_signal_index=<optimized out>, argv=0x7fff83fa3740) at kernel/qobject.cpp:3556
#21 0x00007f7126717695 in KisImageSignalRouter::sigNodeAddedAsync (this=<optimized out>, _t1=...) at /home/boud/kde/build/sketch/krita/image/moc_kis_image_signal_router.cpp:179
#22 0x00007f71268669b9 in KisImageSignalRouter::emitNodeHasBeenAdded (this=0x335f180, parent=<optimized out>, index=<optimized out>) at /home/boud/kde/src/sketch/krita/image/kis_image_signal_router.cpp:78
#23 0x00007f712688c97f in KisNode::add (this=0x335bd30, newNode=..., aboveThis=...) at /home/boud/kde/src/sketch/krita/image/kis_node.cpp:291
#24 0x00007f7126894b85 in KisNodeFacade::addNode (this=this@entry=0x3376ec8, node=..., parent=..., aboveThis=...) at /home/boud/kde/src/sketch/krita/image/kis_node_facade.cpp:123
#25 0x00007f7126895e54 in KisNodeFacade::moveNode (this=this@entry=0x3376ec8, node=..., parent=..., newIndex=newIndex@entry=2) at /home/boud/kde/src/sketch/krita/image/kis_node_facade.cpp:99
#26 0x00007f7126897a8e in KisNodeFacade::lowerNode (this=0x3376ec8, node=...) at /home/boud/kde/src/sketch/krita/image/kis_node_facade.cpp:171
#27 0x00007f71267992fa in KisImageNodeLowerCommand::redo (this=0x6226fd0) at /home/boud/kde/src/sketch/krita/image/commands/kis_image_node_lower_command.cpp:34
#28 0x00007f71254ce60f in KUndo2QStack::push (this=0x32e8ab0, cmd=0x6226fd0) at /home/boud/kde/src/sketch/libs/kundo2/kundo2stack.cpp:569
#29 0x00007f7126911806 in KisDocumentUndoStore::addCommand (this=0x33768c0, command=0x6226fd0) at /home/boud/kde/src/sketch/krita/image/kis_undo_stores.cpp:60
#30 0x00007f7126912690 in KisLegacyUndoAdapter::addCommand (this=0x335f450, command=0x6226fd0) at /home/boud/kde/src/sketch/krita/image/kis_legacy_undo_adapter.cpp:51
#31 0x00007f712768ed26 in KisNodeCommandsAdapter::lower (this=0x3463670, node=...) at /home/boud/kde/src/sketch/krita/ui/kis_node_commands_adapter.cpp:90
#32 0x00007f7127675f3d in KisLayerManager::layerLower (this=0x3463550) at /home/boud/kde/src/sketch/krita/ui/kis_layer_manager.cc:684
#33 0x00007f7127695aad in KisNodeManager::raiseNode (this=0x34634a0) at /home/boud/kde/src/sketch/krita/ui/kis_node_manager.cpp:453
#34 0x000000000046441c in LayerModel::moveDown (this=this@entry=0x2904db0) at /home/boud/kde/src/sketch/krita/sketch/models/LayerModel.cpp:465
#35 0x0000000000467648 in LayerModel::qt_static_metacall (_o=_o@entry=0x2904db0, _id=_id@entry=28, _a=_a@entry=0x7fff83fa4350, _c=<optimized out>) at /home/boud/kde/build/sketch/krita/sketch/LayerModel.moc:191
#36 0x0000000000467da5 in LayerModel::qt_metacall (this=0x2904db0, _c=QMetaObject::InvokeMetaMethod, _id=28, _a=0x7fff83fa4350) at /home/boud/kde/build/sketch/krita/sketch/LayerModel.moc:294
#37 0x00007f7128199d46 in ?? () from /usr/lib64/libQtDeclarative.so.4
#38 0x00007f712819b3a9 in ?? () from /usr/lib64/libQtDeclarative.so.4
#39 0x00007f712819be4b in ?? () from /usr/lib64/libQtDeclarative.so.4
#40 0x00007f711e3ec523 in ?? () from /usr/lib64/libQtScript.so.4
#41 0x00007f711e2e8c50 in ?? () from /usr/lib64/libQtScript.so.4
#42 0x00007f711e2c5eca in ?? () from /usr/lib64/libQtScript.so.4
#43 0x00007f7106a75b83 in ?? ()
#44 0x0000000000000000 in ?? ()
Comment 2 Halla Rempt 2012-10-24 08:38:46 UTC 
Git commit 902f55a915fa8e851f8e5c37e6c5f1e9b7976673 by Boudewijn Rempt.
Committed on 24/10/2012 at 10:36.
Pushed by rempt into branch 'krita-sketch-rempt'.

Don't crash when moving layers

If the active layer is being deleted without telling the activeselection,
we get a crash when accessing the active layer.

M  +12   -2    krita/ui/flake/kis_node_shape.cpp

http://commits.kde.org/calligra/902f55a915fa8e851f8e5c37e6c5f1e9b7976673