When changing the difficulty level while a game is running selecting Cancel actually does not cancel and the game is restarted anyway Reproducible: Always Steps to Reproduce: 1. Start a game 2. Try to change the difficulty level 3. On the dialog choose cancel Actual Results: The game is restarted anyway Expected Results: The game is not restarted
(In reply to comment #0) Hi Albert. A patch to solve this bug has already been made and it's just waiting for revision on Review Board.
Git commit 2ca2c795f2614d963241d00f3594dc7d047850b8 by Roney Gomes. Committed on 18/11/2012 at 19:07. Pushed by roneygomes into branch 'master'. Fix the bug which restarted a game after cancelling change of level. Rather than connect the levelChanged() slot to the selectedLevelChanged() signal it is now connected to the currentLevelChanged() slot, which makes more sense and solves the bug which restarted the game even if the player pressed the "Cancel" button of the warning dialog. REVIEW: 107053 M +3 -1 src/mainwindow.cpp http://commits.kde.org/knavalbattle/2ca2c795f2614d963241d00f3594dc7d047850b8
Two things, do you plan backporting this fix to the 4.9 branch? Also you should set the version fixed in to the version the fix will be in (i.e. 4.10.0 if no backport 4.9.4 if you do the backport)
(In reply to comment #4) > Two things, do you plan backporting this fix to the 4.9 branch? Also you > should set the version fixed in to the version the fix will be in (i.e. > 4.10.0 if no backport 4.9.4 if you do the backport) Didn't think about that, I have to say. Backporting it seems important, I would really appreciate to make it available as soon as possible. Unluckly I don't know how to do this. :-( Will look for information on Tech Base and solve it as fast as I can. Thanks for the reminder.
just commit it to the KDE/4.9 branch
Git commit b51b9bc4785d43c9bcbf4604bd0846f88172a5d8 by Roney Gomes. Committed on 18/11/2012 at 19:07. Pushed by roneygomes into branch 'KDE/4.9'. Fix the bug which restarted a game after cancelling change of level. Rather than connect the levelChanged() slot to the selectedLevelChanged() signal it is now connected to the currentLevelChanged() slot, which makes more sense and solves the bug which restarted the game even if the player pressed the "Cancel" button of the warning dialog. REVIEW: 107053 M +3 -1 src/mainwindow.cpp http://commits.kde.org/knavalbattle/b51b9bc4785d43c9bcbf4604bd0846f88172a5d8