Bug 307994 - Shortcut to expand outgoing replacements
Summary: Shortcut to expand outgoing replacements
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: inputline (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-07 00:09 UTC by Christian (Fuchs)
Modified: 2012-10-17 18:51 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian (Fuchs) 2012-10-07 00:09:47 UTC
As discussed today on IRC: 

It would be handy to have a shortcut which expands all expressions matching outgoing replacements in the input line, so you'd see the result before sending the message.

Reproducible: Always

Steps to Reproduce:
1. Create outgoing replacement
2. Write it in input line
3. Try to expand it before actually sending it
Actual Results:  
Not possible to expand

Expected Results:  
Possible to expand

Cursor position as discussed on IRC, 

 <Sho_> when the cursor is in the expression i'll move it at the end of the replacement
 <Sho_> and otherwise preserve the position
Comment 1 Eike Hein 2012-10-17 18:51:09 UTC
Git commit f4cef9a31d44f8e763ef2315128106754bbe4ede by Eike Hein.
Committed on 17/10/2012 at 20:50.
Pushed by hein into branch 'master'.

Add an action to, rather ironically, manually apply auto-replace.

Use case: Review and customize before send-out. Given this, the code
preserves the relative cursor position to ease editing; if the cursor
is inside a needle during action invocation it's moved to the end of
the replacement.

M  +36   -4    src/application.cpp
M  +1    -1    src/application.h
M  +2    -2    src/irc/inputfilter.cpp
M  +6    -0    src/mainwindow.cpp
M  +17   -1    src/viewer/ircinput.cpp
M  +1    -0    src/viewer/ircinput.h
M  +13   -0    src/viewer/viewcontainer.cpp
M  +1    -0    src/viewer/viewcontainer.h

http://commits.kde.org/konversation/f4cef9a31d44f8e763ef2315128106754bbe4ede