Bug 307928 - [JJ] Some effect authors are listed as "Name1 & Name2"
Summary: [JJ] Some effect authors are listed as "Name1 & Name2"
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-various (show other bugs)
Version: git master
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: 4.10
Assignee: KWin default assignee
URL: https://git.reviewboard.kde.org/r/106...
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2012-10-05 15:25 UTC by Christoph Feck
Modified: 2012-10-18 05:30 UTC (History)
0 users

See Also:
Latest Commit: http://commits.kde.org/kde-workspace/ace3782a0e73e045de9d833797ef19c9b73e18e7
Version Fixed In: 4.10
mgraesslin: ReviewRequest+

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2012-10-05 15:25:50 UTC 
To reproduce
- open the "Info" dialog for the "Invert" effect in the "All Effects" KCM
- select "Author" tab
- look at the author's name
- click the "E-Mail" icon

Actual result:
- a single author with name "Rivo Laks & Lucas Murray" is listed
- the mailer is started with address "r...@hidden.url & l...@hidden.url"

Expected result:
- the two authors are listed separately
- the mailer is started with each address separately
Comment 1 Martin Flöser 2012-10-05 15:41:27 UTC 
the author information is taken from the desktop file. Any idea how to properly specify multiple authors there?
Comment 2 Christoph Feck 2012-10-05 15:48:53 UTC 
s/ & /, /g

(see fade/metadata.desktop)
Comment 3 Martin Flöser 2012-10-05 15:55:48 UTC 
(In reply to comment #2)
> s/ & /, /g
> 
> (see fade/metadata.desktop)
In the hope that the community can take care of it: What Christoph wrote is "sed" syntax which just says that the & should be replace by a ,

So if the .dekstop file lists:
Foo & Bar
It has to become:
Foo, Bar

The errors are in .desktop files in the kwin/effects/ subdirectories of the kde-workspace git repository.
Comment 4 Thomas Lübking 2012-10-05 16:53:42 UTC 
*never* do what the machine can do for you ;-)

find -name "*.desktop" -exec sed -ie 's/\(X-KDE-PluginInfo-Email=.*\)\s\{1,\}&\s*\(.*\)/\1, \2/g' '{}' +
find -name "*.desktop" -exec sed -ie 's/\(X-KDE-PluginInfo-Author=.*\)\s\{1,\}&\s*\(.*\)/\1, \2/g' '{}' +

to just check
find -name "*.desktop" -exec sed -e 's/\(X-KDE-PluginInfo-Email=.*\)\s\{1,\}&\s*\(.*\)/\1, \2/g' '{}' + | grep -E 'X-KDE-PluginInfo-(Email|Author)'
Comment 5 Martin Flöser 2012-10-18 05:30:24 UTC 
Git commit ace3782a0e73e045de9d833797ef19c9b73e18e7 by Martin Gräßlin, on behalf of Alexander Jones.
Committed on 15/10/2012 at 17:02.
Pushed by graesslin into branch 'master'.

Fixing author names in desktop files
FIXED-IN: 4.10
REVIEW: 106880

M  +2    -2    kwin/effects/desktopgrid/desktopgrid.desktop
M  +2    -2    kwin/effects/invert/invert.desktop
M  +2    -2    kwin/effects/logout/logout.desktop
M  +2    -2    kwin/effects/presentwindows/presentwindows.desktop
M  +2    -2    kwin/effects/zoom/zoom.desktop

http://commits.kde.org/kde-workspace/ace3782a0e73e045de9d833797ef19c9b73e18e7