Bug 307837 - Notifications slide out, but "window" stays
Summary: Notifications slide out, but "window" stays
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: notifications (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-04 12:31 UTC by Christoph Feck
Modified: 2012-10-10 15:48 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2012-10-04 12:31:06 UTC
Version: 4.9.80 from master

When clicking "X" on a notification to close it, the contents of that window slides out. The window, however, stays on screen. Either the window slides out completely, or it just closes. Currently, it looks broken.
Comment 1 Christoph Feck 2012-10-04 12:33:37 UTC
> stays on screen

What I mean is that it does not move together with the notification. It actually closes after the content has moved out.
Comment 2 Marco Martin 2012-10-04 12:55:51 UTC
actually is still possible to close manually, by clicking anywhere on the popup (before also had the same behavior, and kpassivepopup was this way too)
the attempt of removing the x was to try to not make the user focus over an element very small to hit.
a report like that is probably saying that the click to dismiss behavior is not discoverable, so may be necessary to reintroduce the x :/
Comment 3 Christoph Feck 2012-10-04 13:37:44 UTC
Oh, right, it closes by just clicking. Once you know, it's of course easier than exactly hitting the "X". Maybe add a text at the bottom "Click to close", until the user actually tried that. This educates, informs, and once it is hidden, no longer disturbes.
Comment 4 Marco Martin 2012-10-04 17:24:12 UTC
Git commit 1f468d60f0f79a9ba00347b46abaa765757aa62d by Marco Martin.
Committed on 04/10/2012 at 19:22.
Pushed by mart into branch 'master'.

show control buttons only on hover

add a close button, shown on hover as well

M  +57   -0    plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml

http://commits.kde.org/kde-workspace/1f468d60f0f79a9ba00347b46abaa765757aa62d
Comment 5 Marco Martin 2012-10-04 17:25:37 UTC
it now tries to show a close button, together scroll buttons only when the mouse is over
may be a good compromise between cleanliness and discoverability
Comment 6 Marco Martin 2012-10-04 18:34:47 UTC
committed to wrong bug #, should be 307836
Comment 7 Christoph Feck 2012-10-05 16:47:08 UTC
I noticed the behavior is different when there is only one notification in the list, or multiple of them.

When there are multiple, clicking X in them makes the respective item slide out. If you click on the master X, then the dialog just closes without any sliding. So far, so good.

When there is only a single item, clicking X makes it slide out, leaving an empty window. It could simply close the window as if it was the master X.
Comment 8 Marco Martin 2012-10-10 15:48:03 UTC
Git commit 0305f0a4fc33db2d1a6e212ae4290d7f55ef1f4a by Marco Martin.
Committed on 10/10/2012 at 17:46.
Pushed by mart into branch 'master'.

use the animation only when there is more than 1 notif

M  +7    -1    plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml

http://commits.kde.org/kde-workspace/0305f0a4fc33db2d1a6e212ae4290d7f55ef1f4a