Bug 307019 - Inconsistent "Do Not Save" button height in Save Documents confirmation dialog
Summary: Inconsistent "Do Not Save" button height in Save Documents confirmation dialog
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR minor
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-19 07:11 UTC by Alex
Modified: 2012-10-26 22:53 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/kate/46a120897472c0d280d862f1fc2e555af49e539d
Version Fixed In:
Sentry Crash Report:

Attachments
Button Height (21.79 KB, image/png)
2012-09-19 07:12 UTC, Alex 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2012-09-19 07:11:54 UTC 
Kate 3.7.4
KDE 4.7.4
"Do Not Save" button has inconsistent height in Save Documents confirmation dialog (due to missing icon I assume). See picture attached.

Reproducible: Always

Steps to Reproduce:
1. open/create document
2. add any changes
3. try to quit Kate
Actual Results:  
"Do Not Save" button's height differs from other buttons' height

Expected Results:  
All buttons should have the same height
Comment 1 Alex 2012-09-19 07:12:25 UTC 
Created attachment 74019 [details]
Button Height
Comment 2 Christoph Feck 2012-09-19 09:51:04 UTC 
Is it different on other dialogs where buttons with and without icons are mixed?
Comment 3 Alex 2012-09-22 08:20:52 UTC 
Not sure, all other dialogs I managed to find in Kate either have icons on all buttons or none of icons at all.
Comment 4 Christoph Cullmann 2012-10-26 22:53:06 UTC 
Git commit 46a120897472c0d280d862f1fc2e555af49e539d by Christoph Cullmann.
Committed on 27/10/2012 at 00:51.
Pushed by cullmann into branch 'master'.

fix button order and button icon/size in save document dialog
thanks for hints
Related: bug 307020

M  +4    -8    kate/app/katesavemodifieddialog.cpp

http://commits.kde.org/kate/46a120897472c0d280d862f1fc2e555af49e539d