Bug 306309 - Reording of shapes stops working
Summary: Reording of shapes stops working
Status: RESOLVED FIXED
Alias: None
Product: calligracommon
Classification: Applications
Component: flake (show other bugs)
Version: 2.5.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Calligra Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-05 19:13 UTC by T Zachmann
Modified: 2012-09-05 19:22 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Document that can be used for testing (4.21 KB, application/vnd.oasis.opendocument.graphics)
2012-09-05 19:16 UTC, T Zachmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description T Zachmann 2012-09-05 19:13:27 UTC
The problem is located in the code that the min zIndex was set to -2^13 = -13 instead of -2 << 12; 

The patch fixes that be calculating the minium zIndex from the defined MaxZIndex

Reproducible: Always

Steps to Reproduce:
1.Open the attached document
2. Select the lowest shape in the Layer view docker
3. press raise and lower 6 times
4. press raise 2 times

Actual Results:  
the second raise no longer raises the object.

Expected Results:  
the second raise should work
Comment 1 T Zachmann 2012-09-05 19:16:14 UTC
Created attachment 73679 [details]
Document that can be used for testing
Comment 2 T Zachmann 2012-09-05 19:18:17 UTC
Git commit 1133dfb085eb196fff130d9a0c876e4b9c78d641 by Thorsten Zachmann.
Committed on 05/09/2012 at 21:16.
Pushed by zachmann into branch 'master'.

Fix reording of shapes.

The problem is located in the code that the min zIndex was set to -2^13 which
equals -13 instead of -2 << 12;

The patch fixes that be calculating the minium zIndex from the defined MaxZIndex

M  +2    -2    libs/flake/commands/KoShapeReorderCommand.cpp

http://commits.kde.org/calligra/1133dfb085eb196fff130d9a0c876e4b9c78d641
Comment 3 T Zachmann 2012-09-05 19:22:07 UTC
Git commit 1b09b3e9822b9386c97f2b474efdf4595e9ddada by Thorsten Zachmann.
Committed on 05/09/2012 at 21:16.
Pushed by zachmann into branch 'calligra/2.5'.

Fix reording of shapes.

The problem is located in the code that the min zIndex was set to -2^13 which
equals -13 instead of -2 << 12;

The patch fixes that be calculating the minium zIndex from the defined MaxZIndex
(cherry picked from commit 1133dfb085eb196fff130d9a0c876e4b9c78d641)

M  +2    -2    libs/flake/commands/KoShapeReorderCommand.cpp

http://commits.kde.org/calligra/1b09b3e9822b9386c97f2b474efdf4595e9ddada