Bug 305228 - Untranslated strings in "Order by" and "Additional Information" menu items
Summary: Untranslated strings in "Order by" and "Additional Information" menu items
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 2.1
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Frank Reininghaus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-15 23:35 UTC by Luigi Toscano
Modified: 2012-08-24 17:01 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.1
Sentry Crash Report:


Attachments
Image showing the problem (98.06 KB, image/png)
2012-08-15 23:36 UTC, Luigi Toscano
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Luigi Toscano 2012-08-15 23:35:42 UTC
The entries of the "Order by" and "Additional Information" menu items under View are not translated, even if the relevant translation files (Italian translation, in this case) are completely translated.

It looks like they are related to nepomuk and/or ontologies (Size, Date, Type, Rating, Tags, Comment, etc)

Reproducible: Always

Steps to Reproduce:
See the attached image
Comment 1 Luigi Toscano 2012-08-15 23:36:27 UTC
Created attachment 73201 [details]
Image showing the problem
Comment 2 Albert Astals Cid 2012-08-15 23:39:24 UTC
Bugfix at https://git.reviewboard.kde.org/r/106049/

It's sad this used to work at 4.8 and broke for 4.9, would be cool if you investigated what happened so it stooped working
Comment 3 Albert Astals Cid 2012-08-16 20:31:26 UTC
Git commit 199fabbaa8d8a12fb49e4c9922c38ec8b033923c by Albert Astals Cid.
Committed on 16/08/2012 at 22:27.
Pushed by aacid into branch 'KDE/4.9'.

Fix translations not showing in the Sort by and Additional Information submenus

Acked by Frank
REVIEW: 106049
FIXED-IN: 4.9.1

M  +3    -3    dolphin/src/kitemviews/kfileitemmodel.cpp

http://commits.kde.org/kde-baseapps/199fabbaa8d8a12fb49e4c9922c38ec8b033923c
Comment 4 Albert Astals Cid 2012-08-16 20:32:59 UTC
Git commit 1e289d5eb022cd51ed87116290c6f2c22f0c01a1 by Albert Astals Cid.
Committed on 16/08/2012 at 22:27.
Pushed by aacid into branch 'master'.

Fix translations not showing in the Sort by and Additional Information submenus

Acked by Frank
REVIEW: 106049
FIXED-IN: 4.9.1
(cherry picked from commit 199fabbaa8d8a12fb49e4c9922c38ec8b033923c)

M  +3    -3    dolphin/src/kitemviews/kfileitemmodel.cpp

http://commits.kde.org/kde-baseapps/1e289d5eb022cd51ed87116290c6f2c22f0c01a1
Comment 5 Frank Reininghaus 2012-08-24 16:58:09 UTC
Git commit 168d0511c754008cc679589566d961beb9f6cc10 by Frank Reininghaus.
Committed on 24/08/2012 at 18:51.
Pushed by freininghaus into branch 'KDE/4.9'.

Fix regression that caused "(I18N_EMPTY_MESSAGE)" sub menus in menus

For top-level roles like "Name" and "Size", the group translation is 0.
In that case, the "group" member of the corresponding RoleInfo struct
must be an empty string. This is expected by the code which generates
Dolphin's menus, which group the top-level roles into a sub menu with
the name "(I18N_EMPTY_MESSAGE)" otherwise. This is a recent regression
caused by 199fabbaa8d8a12fb49e4c9922c38ec8b033923c.

Thanks to Christoph Feck for investigating this issue!

M  +8    -1    dolphin/src/kitemviews/kfileitemmodel.cpp

http://commits.kde.org/kde-baseapps/168d0511c754008cc679589566d961beb9f6cc10
Comment 6 Frank Reininghaus 2012-08-24 17:01:17 UTC
Git commit ee63c6c719a650795051d5ad1ecc01856853d254 by Frank Reininghaus.
Committed on 24/08/2012 at 18:51.
Pushed by freininghaus into branch 'master'.

Fix regression that caused "(I18N_EMPTY_MESSAGE)" sub menus in menus

For top-level roles like "Name" and "Size", the group translation is 0.
In that case, the "group" member of the corresponding RoleInfo struct
must be an empty string. This is expected by the code which generates
Dolphin's menus, which group the top-level roles into a sub menu with
the name "(I18N_EMPTY_MESSAGE)" otherwise. This is a recent regression
caused by 199fabbaa8d8a12fb49e4c9922c38ec8b033923c.

Thanks to Christoph Feck for investigating this issue!
(cherry picked from commit 168d0511c754008cc679589566d961beb9f6cc10)

M  +8    -1    dolphin/src/kitemviews/kfileitemmodel.cpp

http://commits.kde.org/kde-baseapps/ee63c6c719a650795051d5ad1ecc01856853d254