Version: okular-4.9.0-1.fc18.x86_64 Reproducible: Always Steps to Reproduce: 1. Open a pdf 2. Show review toolbar (Tools -> Review) 3. Change to text selection tool 4. Review toolbar is hidden, but togglebutton remains checked Patch attached.
Created attachment 72972 [details] Patch Patch ensures Review togglebutton remains consistent when changing tool.
I'll have a look at the patch "soon"
Hi Sandro, i see that PageView::slotSetMouseZoom and a few other methods seem to have the same construct, so they'd might need the same fix, can you check that? Thanks!
Created attachment 73112 [details] Updated patch Hello Albert, yes you are right, I've updated the patch accordingly.
Back to me
This breaks one of the features that was that if you were with the review toolbar shown, switched to Selection Tool, and then switched to Browse Tool the review toolbar was shown again, as noted in void PageView::slotSetMouseNormal() { ... // reshow the annotator toolbar if hiding was forced ... } This is now broken because it wrongly depended in d->aToggleAnnotator->isChecked(), can you please add some code to your patch so that this feature still works? Thanks :-)
Created attachment 73128 [details] Patch v3 I also added a missing delete d->annotator in the PageView destructor.
There's no need to delete the d->annotator, QObject will take care of that. The rest of the patch seems ok barring spacing and code in the header. I'll have a look probably tomorrow
Created attachment 73135 [details] Patch v4 Whoops, missed the QObject inherticance. Removed the delete statement and added the missing space.
There's still a problem if i do this: * Ctrl+3 * F6 * Ctrl+3 * F6 In this situation i'm seeing the review tool bar but the menu is unchecked. Can you have a look?
Will have a look tomorrow or tuesday.
Created attachment 73406 [details] Patch v5 Ok, should really work correctly now...
Git commit a2dd088ebd5511477d0bc6dec6b407886f915772 by Albert Astals Cid, on behalf of Sandro Mani. Committed on 27/08/2012 at 20:59. Pushed by aacid into branch 'KDE/4.9'. Fix Tools->review inconsistency when switching tool FIXED-IN: 4.9.1 M +24 -11 ui/pageview.cpp M +11 -1 ui/pageviewannotator.cpp M +4 -0 ui/pageviewannotator.h http://commits.kde.org/okular/a2dd088ebd5511477d0bc6dec6b407886f915772
Git commit 56dd5278d29d117ac9ee04faabea46d7599ecfe7 by Albert Astals Cid, on behalf of Sandro Mani. Committed on 27/08/2012 at 20:59. Pushed by aacid into branch 'master'. Fix Tools->review inconsistency when switching tool FIXED-IN: 4.9.1 (cherry picked from commit a2dd088ebd5511477d0bc6dec6b407886f915772) M +24 -11 ui/pageview.cpp M +11 -1 ui/pageviewannotator.cpp M +4 -0 ui/pageviewannotator.h http://commits.kde.org/okular/56dd5278d29d117ac9ee04faabea46d7599ecfe7