Bug 302833 - clientPopup: "'More actions' and "Attach as tab to" lack mnemonics
Summary: clientPopup: "'More actions' and "Attach as tab to" lack mnemonics
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: 4.8.90
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: 4.11
Assignee: KWin default assignee
URL: https://git.reviewboard.kde.org/r/110...
Keywords:
: 317996 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-07-01 14:24 UTC by Dave Gilbert
Modified: 2013-05-19 15:48 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.11
thomas.luebking: ReviewRequest+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Gilbert 2012-07-01 14:24:27 UTC
On the Alt-space menu the option 'More actions' has no shortcut.
This makes it hard to get to some of the actions I use commonly (like the keep above)

(Attach as tab to - also doesn't have a shortcut)

Reproducible: Always

Steps to Reproduce:
1. Alt space on any window

Actual Results:  
Menu appears, the option 'More Actions' doesn't have any shortcut

Expected Results:  
More Actions would have a shortcut on the menu (M?)

(Actually there are some of the options on More Actions I'd rather have on the main menu - Gnome2 has 'Always on top' on the main menu and I do use it a lot).
Comment 1 Thomas Lübking 2012-07-01 16:30:24 UTC
FYI: The default shortcut for the menu is Alt+F3 and those things are called "mnemonics" - shortcuts is what you use w/o menus, not to navigate in one (and btw. can assign to keep above etc., so you don't have to invoke the popup at all)

On the bug/wish:
&M and &A seems untaken in resp. contexts, but i guess we'd break string freeze by that - so it will in doubt have to wait for 4.10 :-(
Comment 2 Dave Gilbert 2012-07-01 16:40:31 UTC
Thanks for fixing my terminology.

Is it possible to edit those mnemonics/menus as a user?  (If not it's a shame - pretty every other menu seems editable).

If it helps as a reason to break the string freeze, I would say it's a regression over 4.7 where there is a mnemonic for 'advanced' which I think was the old name,
Comment 3 Thomas Lübking 2012-07-01 16:44:51 UTC
> If not it's a shame - pretty every other menu seems editable
Humm? You can edit shortcuts but how do you edit mnemonics? They're often even autopicked by the toolkits (what might be a way around string freeze btw.)
Comment 4 Dave Gilbert 2012-07-01 16:48:09 UTC
Hmm, you seem to have lost part of my previous comment - I can see it in the web interface here; lets try again:

1) Is it possible to edit the mnemonic used in the menu as a user/via configuration rather than a rebuild?

2) I believe this is a regression over 4.7 where there was a mnemonic for 'advanced' on the menu.
Comment 5 Thomas Lübking 2012-07-01 16:52:21 UTC
No, not lost - i was responding.

So again: how do you edit mnemonics at all?
Eg. the mnemonic to minimize windows is and remains "n" while i set the shortcut to ctrl+alt+shift+left
Comment 6 Dave Gilbert 2012-07-01 16:56:17 UTC
> So again: how do you edit mnemonics at all?

That was my question! I was just wondering if there was a way to work around this if it has to wait for 4.10 to be really fixed.

If there is no GUI way of editing it, is there a string file I can go and tweak in my install to change the mnemonic.
Comment 7 Thomas Lübking 2012-07-01 17:00:59 UTC
Once more: you *stated*
> If not it's a shame - pretty every other menu seems editable

And I want to know "how" - I'm not aware of *any* way to alter *any* mnemonic, so if you actually can alter mnemonics and tell me how i'm gonna tell you whether this is possible or can be enabled for this menu.
Comment 8 Dave Gilbert 2012-07-01 17:48:15 UTC
Yeh I think you're right, there doesn't seem to be a way to alter mnemonics; I've put a global shortcut in for now (although in 3 years time I'll probably be swearing for days when I try to use the combination in a different program until I remember....)
Comment 9 Martin Flöser 2012-07-01 19:00:55 UTC
probably too late for 4.9, but I could ask Albert (language and release coordinator) tomorrow. It would be most appreciated if you could work on it (I have stopped caring about mnemonics about a decade ago to be honest).

The code is in kde-workspace/kwin/useractions.cpp
Comment 10 Thomas Lübking 2013-04-07 22:26:53 UTC
*** Bug 317996 has been marked as a duplicate of this bug. ***
Comment 11 Thomas Lübking 2013-05-12 06:49:18 UTC
*** Bug 319695 has been marked as a duplicate of this bug. ***
Comment 12 Thomas Lübking 2013-05-15 20:39:12 UTC
Git commit 1bcc8c985d438505f463f06c33d2edfaae922a8b by Thomas Lübking.
Committed on 15/05/2013 at 20:55.
Pushed by luebking into branch 'master'.

add mnemonics to tabbing and "more actions"
FIXED-IN: 4.11
REVIEW: 110402

M  +2    -2    kwin/useractions.cpp

http://commits.kde.org/kde-workspace/1bcc8c985d438505f463f06c33d2edfaae922a8b
Comment 13 Dave Gilbert 2013-05-19 15:48:50 UTC
Thanks Thomas!