Bug 302470 - Use document-import/export instead of arrows for Import/Export of VPN settings
Summary: Use document-import/export instead of arrows for Import/Export of VPN settings
Status: RESOLVED FIXED
Alias: None
Product: solid
Classification: Frameworks and Libraries
Component: networkmanagement-kcm (show other bugs)
Version: 4.8.80 (beta1)
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: Will Stephenson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-24 23:10 UTC by Kai Uwe Broulik
Modified: 2012-06-26 15:26 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2012-06-24 23:10:05 UTC
The VPN part of the network KCM uses arrow-down and arrow-up for VPN settings import/export. Those can easily be confused with the arrows common to sort a list. To me it also isn’t neccessarily clear from the icon which button does which. I think document-import / document-export are better suited for those button.

Reproducible: Always
Comment 1 Lamarque V. Souza 2012-06-26 13:13:27 UTC
There are also the texts "Import" and "Export" beside the icons. Using long text like "document-import" is going to cause troubles with languages with long translations, you know that.
Comment 2 Kai Uwe Broulik 2012-06-26 15:09:27 UTC
Didn't know icon names need to be translated and displayed in the UI ...
Comment 3 Lamarque V. Souza 2012-06-26 15:24:28 UTC
ah you mean the icon names, I thought you were talking about the text. I will change them although with the text besides the button I am pretty sure nobody would have any doubt about what the button do.
Comment 4 Lamarque V. Souza 2012-06-26 15:25:23 UTC
Git commit f74a2ecb1ab20e6e16bf3277f20ce7db8d65c177 by Lamarque V. Souza.
Committed on 26/06/2012 at 17:21.
Pushed by lvsouza into branch 'master'.

Change icons used in the VPN import/export buttons in the kcm.

M  +2    -2    settings/config/addeditdeletebuttonset.cpp

http://commits.kde.org/networkmanagement/f74a2ecb1ab20e6e16bf3277f20ce7db8d65c177
Comment 5 Lamarque V. Souza 2012-06-26 15:26:21 UTC
Git commit ccb7d4d27bbe917e8aeaf85024d17cea7566d8e3 by Lamarque V. Souza.
Committed on 26/06/2012 at 17:21.
Pushed by lvsouza into branch 'nm09'.

Change icons used in the VPN import/export buttons in the kcm.
(cherry picked from commit f74a2ecb1ab20e6e16bf3277f20ce7db8d65c177)

M  +1    -1    plasma_nm_version.h
M  +2    -2    settings/config/addeditdeletebuttonset.cpp

http://commits.kde.org/networkmanagement/ccb7d4d27bbe917e8aeaf85024d17cea7566d8e3