Bug 299163 - Effects cannot be configured
Summary: Effects cannot be configured
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: compositing (show other bugs)
Version: git master
Platform: unspecified Linux
: NOR normal
Target Milestone: 4.9
Assignee: KWin default assignee
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2012-05-01 12:03 UTC by Martin Flöser
Modified: 2012-05-02 15:45 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Flöser 2012-05-01 12:03:10 UTC
Any change in the configuration of an effect is not applied due to change in 
236d4c81bc75768dbc8cf5e334cd78f855e31b06

The effects configuration use EffectsHandler::effectConfig which returns a wrong config file when used from kcmshell.

Trivial fix: revert the commit.Better fix: make config modules not use EffectsHandler, as that would also mean they don't have to link the kwineffects lib.
Comment 1 Martin Flöser 2012-05-02 15:45:33 UTC
Git commit 8f31f53ce7e942884f1d9ac30783745785102875 by Martin Gräßlin.
Committed on 01/05/2012 at 16:15.
Pushed by graesslin into branch 'master'.

Revert 236d4c8 for EffectsHanlder::effectConfig

EffectConfig is used also in the config modules which
means kwinrc needs to be explicitly specified.
REVIEW: 104808

M  +2    -1    kwin/libkwineffects/kwineffects.cpp

http://commits.kde.org/kde-workspace/8f31f53ce7e942884f1d9ac30783745785102875