Bug 297809 - Elevate windows in addition to highlight
Summary: Elevate windows in addition to highlight
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: tabbox (show other bugs)
Version: 4.8.1
Platform: unspecified Linux
: NOR wishlist
Target Milestone: 4.9
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-09 23:33 UTC by aditsu
Modified: 2012-04-14 21:23 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 4.9


Attachments
screenshot (216.14 KB, image/jpeg)
2012-04-09 23:33 UTC, aditsu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description aditsu 2012-04-09 23:33:32 UTC
Created attachment 70276 [details]
screenshot

When switching windows with the layout based switcher, it shows me a useless garbled mess of transparent windows, with no obvious meaning or purpose. When the box switch was available (before it was murdered in KDE 4.8), it nicely brought the current window to front.
Comment 1 Thomas Lübking 2012-04-09 23:58:42 UTC
This is not related to the switcher layout - you've highlight windows checked (which does not elevate the window for other reasons, mainly plasma popups - we actually might want to fix that, since it's still marked todo)


PS.
If you'd like a good advice to get into some constructive discussion with the kwin maintainer: watch your tone - maybe sleep a night over it or so.

martin can decide himself on this one as well :-P
Comment 2 aditsu 2012-04-10 00:37:47 UTC
The layout based switcher is the only effect where I noticed this problem. Maybe it's not the effect's fault, but anyway, I do want to highlight the selected window. Everything was working *beautifully* in KDE 4.7 with the box switch, I just can't understand why it is being removed and replaced with an inferior/broken switcher.
Comment 3 Martin Flöser 2012-04-10 04:33:12 UTC
(In reply to comment #0)
> When the box switch was available (before it was murdered in KDE 4.8), it
> nicely brought the current window to front.
(In reply to comment #2)
> Everything was working *beautifully* in KDE 4.7 with the
> box switch, I just can't understand why it is being removed and replaced
> with an inferior/broken switcher.
If you want to get things improved it really helps to not talk about "was murdered" and "replaced with an inferior/broken". This does not motivate me to put any work on this - I have enough things to work on to not considering bug reports where my work is diminished. Please consider your tone the next time you report bugs/feature requests.

That said: you can still use BoxSwitch in 4.8. It's a hidden option, but it is still available (so not murdered at all). Even in current master it is still around.

And now to the feature request: I might consider adding elevation to the highlight windows effect to be used only from TabBox - that might make sense.
Comment 4 aditsu 2012-04-10 07:31:14 UTC
I'm sorry if my words were too aggressive, I was just frustrated about the situation.
Could you please explain how to use BoxSwitch in 4.8?
Comment 5 aditsu 2012-04-12 12:20:31 UTC
For the record: BoxSwitch discussion continued in bug 297806
Comment 6 Thomas Lübking 2012-04-12 12:46:41 UTC
FTR:
http://git.reviewboard.kde.org/r/104538/

FTFR:
discussion should actually not happen in a bugtracker at all, but on forum.kde.org (eg. brainstorm)
Comment 7 Thomas Lübking 2012-04-14 21:22:37 UTC
Git commit 143a8325e3ab530184d2ec568fc3c35924f068c0 by Thomas Lübking.
Committed on 11/04/2012 at 01:19.
Pushed by luebking into branch 'master'.

use compositor to elevate current tabbox window
REVIEW: 104538

M  +9    -0    kwin/tabbox/tabbox.cpp
M  +1    -0    kwin/tabbox/tabbox.h
M  +10   -1    kwin/tabbox/tabboxhandler.cpp
M  +5    -0    kwin/tabbox/tabboxhandler.h

http://commits.kde.org/kde-workspace/143a8325e3ab530184d2ec568fc3c35924f068c0
Comment 8 Thomas Lübking 2012-04-14 21:23:58 UTC
forgot version updates for Martins nifty script ;-)