Bug 296667 - Style of arrow changes on save/load
Summary: Style of arrow changes on save/load
Status: RESOLVED FIXED
Alias: None
Product: calligracommon
Classification: Applications
Component: text-layout (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR critical
Target Milestone: ---
Assignee: Calligra Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-24 06:04 UTC by T Zachmann
Modified: 2012-03-25 04:39 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Document showing the problem (13.87 KB, application/vnd.oasis.opendocument.presentation)
2012-03-24 06:05 UTC, T Zachmann 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description T Zachmann 2012-03-24 06:04:05 UTC 
User-Agent:       Mozilla/5.0 (compatible; Konqueror/4.6; Linux) KHTML/4.6.5 (like Gecko) Kubuntu
Build Identifier: 

When load, save and load of the attached presentation the style of the arrow changes.

Reproducible: Always
Comment 1 T Zachmann 2012-03-24 06:05:11 UTC 
Created attachment 69843 [details]
Document showing the problem
Comment 2 T Zachmann 2012-03-24 06:12:17 UTC 
Git commit a5ee384ae82995461d89fe623c714405f8948e00 by Thorsten Zachmann.
Committed on 24/03/2012 at 07:01.
Pushed by zachmann into branch 'master'.

Don't remove to much on removeDuplicates.

When the font-familiy is set after the removing of duplicates also keep the
properties font-pitch, font-family-generic and font-charset as these are only
evaluated if there is a font-family on the same style level.

Please review so I can backport to 2.4 branch.

Roundtrip tested with my odp and odt test set.

CCMAIL: calligra-devel@kde.org

M  +22   -5    libs/kotext/styles/KoCharacterStyle.cpp

http://commits.kde.org/calligra/a5ee384ae82995461d89fe623c714405f8948e00
Comment 3 T Zachmann 2012-03-24 06:12:21 UTC 
Git commit a5ee384ae82995461d89fe623c714405f8948e00 by Thorsten Zachmann.
Committed on 24/03/2012 at 07:01.
Pushed by zachmann into branch 'master'.

Don't remove to much on removeDuplicates.

When the font-familiy is set after the removing of duplicates also keep the
properties font-pitch, font-family-generic and font-charset as these are only
evaluated if there is a font-family on the same style level.

Please review so I can backport to 2.4 branch.

Roundtrip tested with my odp and odt test set.

CCMAIL: calligra-devel@kde.org

M  +22   -5    libs/kotext/styles/KoCharacterStyle.cpp

http://commits.kde.org/calligra/a5ee384ae82995461d89fe623c714405f8948e00
Comment 4 T Zachmann 2012-03-25 04:39:34 UTC 
Git commit b3f0cacd418e534ca36727576c503c11ea966e60 by Thorsten Zachmann.
Committed on 24/03/2012 at 07:01.
Pushed by zachmann into branch 'calligra/2.4'.

Don't remove to much on removeDuplicates.

When the font-familiy is set after the removing of duplicates also keep the
properties font-pitch, font-family-generic and font-charset as these are only
evaluated if there is a font-family on the same style level.

Please review so I can backport to 2.4 branch.

Roundtrip tested with my odp and odt test set.

CCMAIL: calligra-devel@kde.org
Review by: boemann
(cherry picked from commit a5ee384ae82995461d89fe623c714405f8948e00)

M  +22   -5    libs/kotext/styles/KoCharacterStyle.cpp

http://commits.kde.org/calligra/b3f0cacd418e534ca36727576c503c11ea966e60