Bug 296536 - in ktorrent i can' t control torrents order manually
Summary: in ktorrent i can' t control torrents order manually
Status: RESOLVED FIXED
Alias: None
Product: ktorrent
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Joris Guisson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 04:40 UTC by cornel panceac
Modified: 2012-07-20 23:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description cornel panceac 2012-03-22 04:40:15 UTC
since updatng to ktorrent 4.2 i'm no longer able to control torrents download order. this was possible in previous (4.1) version of ktorrent. The qeue manager seems to work but it actually doesn't. Whatever order i choose there, it's ignored while the application is running and it's forgotten once i close it. The "control torrents manually" option is checked under "qeue manager" but it makes no difference and, "maximum downloads" and "maximum seeds" are greyed out and set to 3/5. also, "stalled timer" and "decrease priority" are greyed out and uncontrolable. another "improvement" is that i no longer can order torrents by status, this column is gone. this happens in fedora 16 x86.

$ rpm -q ktorrent
ktorrent-4.2.0-1.fc16.i686

previous, working, version was:
ktorrent-4.1.3-1.fc16.i686
Comment 1 Joris Guisson 2012-03-22 17:29:35 UTC
Euhm, if you have control torrents manually checked, then the queue manager does nothing. You have to uncheck that. Then you have to start the torrents you want to run, and the queue manager should do the rest.
Comment 2 cornel panceac 2012-03-22 18:38:17 UTC
Joris, how do i control the torrents manually if i have that checked? 

Anyway, i have unchecked that option (control torrents manually) then moved (in the qeue manager) the torrents i want to download first in the first three positions and ktorrent started and completed downloading someting else, never those first three torrents.

I'm sorry but i no longer understand how this application work.
Comment 3 cornel panceac 2012-03-23 04:45:24 UTC
Joris, with "control torrents manually" unchecked, after restarting ktorrent, the qeue is still in whatever order ktorrent decides, and as usual, ktorrent ddownloads one of the 12 torrents it already started at one point or another in time.
Comment 4 Joris Guisson 2012-03-24 11:24:57 UTC
If control torrents manually is checked, you control which gets downloaded  and not the queue manager. If it is not checked the queue manager is in charge.

With control torrents manually unchecked, you still have to tell the queue manager which torrents it needs to run, you do that by starting those torrents. The queue manager will then run the configured amount of each kind using the order you set in the queue manager widget.
Comment 5 cornel panceac 2012-03-24 11:50:30 UTC
This was maybe true in the previous version of ktorrent. In 4.2 i can no longer control what is downloaded , it's ktorrent which decides this, wether that box is checked or unchecked.
Comment 6 cornel panceac 2012-03-24 11:57:35 UTC
i've just discovered that right clicking on the torrent, when that box is checked, allows me to start a particular torrent. how do i know in what state a torrent is (qeued, stoped, etc) ?

for now i'd say this is a good workaround for the uncontrollable qeue manager.
Comment 7 Joris Guisson 2012-03-27 16:32:27 UTC
Queue manager disabled or not, in both cases you have to start the torrents yourself. The QM will just run the number of torrents specified in the settings taking into account the order, and if you disable it, all the ones you started will run at the same time.
Comment 8 cornel panceac 2012-03-27 17:08:01 UTC
(In reply to comment #7)
> Queue manager disabled or not, in both cases you have to start the torrents
> yourself. The QM will just run the number of torrents specified in the
> settings taking into account the order, and if you disable it, all the ones
> you started will run at the same time.

So you're saying that ktorrent deciding at every next start the torrents order in the qeue manager is a feature? 

And i *have* to right click on torrents to start them wether the "control torrents manually" is set or not?
Comment 9 Julien Bigot 2012-04-01 14:06:44 UTC
I have the same problem since update to 4.2 (debian package)

currently I have 12 torrents in the queue, all of them handled by the queue manager (all of them finished downloading).
I've set the queue manager to upload 5 torrents in parallel. ktorrent is currently uploading torrents #6 #8 #9 #11 & #12. If I reorder the torrents in the queue, ktorrent will change the active torrents so that the exact same rank in the queue keep being uploaded. However if I minimize ktorrent to the tray and reopen it, a completely different set of ranks might be downloading.

If i look at the torrent priority over dbus, those active are those with the higher priority (that don't match their rank in the queue manager)

The exact same behavior happens wether its downloading or uploading.
Comment 10 Julien Bigot 2012-04-01 14:13:28 UTC
I've just discovered that clicking the "show/hide all not queued torrents" button close to the queue manager (wether activating or deactivating it) updates the display and gets the torrents in the right order (i.e. the one that corresponds to the order torrents are actually downloading and to the info provided over dbus)
Comment 11 Joris Guisson 2012-04-03 16:11:17 UTC
That button only hides or shows items, should have nothing to do with the order.

Note that there is a feature to decrease the priority of torrents when they are stalled for to long. Is this on ? You can find it in the queue manager settings. If this is on, that would perfectly explain the order being changed.
Comment 12 Julien Bigot 2012-04-03 16:30:14 UTC
(In reply to comment #11)
> That button only hides or shows items, should have nothing to do with the
> order.

Exactly, that's why I call that a bug.

> Note that there is a feature to decrease the priority of torrents when they
> are stalled for to long. Is this on ? You can find it in the queue manager
> settings. If this is on, that would perfectly explain the order being
> changed.

I've disabled it, but even if it was enabled, clicking the "show/hide all not queued torrents" should'nt change the order. It looks like a randomly reordered list is displayed until you click that button that results in a refresh of the list that then gets the right order. When the list is randomly reodered, moving the torrents in the lists actually changes their rank but not to the right position.
Comment 13 Joris Guisson 2012-04-09 19:32:12 UTC
Git commit 3b43c6f4829cd274ceee6d1416501bf84006f459 by Joris Guisson.
Committed on 09/04/2012 at 21:31.
Pushed by guisson into branch 'master'.

Fix Queue Manager widget getting the priorities wrong

M  +1    -0    ChangeLog
M  +30   -4    ktorrent/tools/queuemanagermodel.cpp
M  +2    -0    ktorrent/tools/queuemanagermodel.h

http://commits.kde.org/ktorrent/3b43c6f4829cd274ceee6d1416501bf84006f459
Comment 14 Joris Guisson 2012-04-09 19:33:19 UTC
Git commit 3dbeb034e769210c71cf7582c274b3501f1df4eb by Joris Guisson.
Committed on 09/04/2012 at 21:31.
Pushed by guisson into branch '4.2'.

Backport to 4.2: Fix Queue Manager widget getting the priorities wrong

M  +1    -0    ChangeLog
M  +30   -4    ktorrent/tools/queuemanagermodel.cpp
M  +2    -0    ktorrent/tools/queuemanagermodel.h

http://commits.kde.org/ktorrent/3dbeb034e769210c71cf7582c274b3501f1df4eb
Comment 15 Julien Bigot 2012-04-10 21:17:04 UTC
Thanks a lot Joris. Sorry I wasn't more clear about what the bug was, but you managed to solve it anyway. You rock! Keep up the good work on that great software.
Comment 16 Syam 2012-07-20 23:47:59 UTC
I too have this problem with KTorrent v4.2.1. Don't know if the patch was applicable to this version. The entries in the queue seems to be re-arranged randomly.