Bug 296271 - Header isn't rendered in some cases
Summary: Header isn't rendered in some cases
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: log-viewer (show other bugs)
Version: git-latest
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: 0.4.1
Assignee: Daniele E. Domenichelli
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-18 12:04 UTC by Elias Probst
Modified: 2012-07-10 22:59 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot showing broken header in log-viewer (75.34 KB, image/png)
2012-03-18 12:04 UTC, Elias Probst
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Probst 2012-03-18 12:04:42 UTC
Created attachment 69709 [details]
Screenshot showing broken header in log-viewer

Sometimes when clicking on a contact in the log-viewer, no header is rendered and instead a "no image found" icon + the string "%topic%" is being shown.

I couldn't find a way yet to reproduce this as it seems to happen randomly for any kind of contact - it even happens for contacts which worked just fine 2 clicks earlier.

See attached screenshot for an example.
Comment 1 Daniele E. Domenichelli 2012-03-19 01:32:27 UTC
This is probably a but introduced by my recent changes to adium themes stuff
The %topic% header should be replacing the header for group chats. That means that instead of the file Header.html the file Topic.html is used

But the %topic% replacement is probably not done yet, and perhaps also some %image% replacement is missing.

But I really have no idea why this happens randomly, perhaps this is a bug in telepathy-logger, that reports randomly that a chat is a group chat...
Comment 2 Daniele E. Domenichelli 2012-04-30 00:18:59 UTC
This seem to be fixed, can anyone else confirm it and eventually close it?
Comment 3 Daniel Vrátil 2012-07-10 22:59:10 UTC
Git commit 29fc2479c6abcc49aa7b076cea919e88c79503b6 by Dan Vrátil.
Committed on 11/07/2012 at 00:57.
Pushed by dvratil into branch 'kde-telepathy-0.4'.

Initialize AdiumThemeHeaderInfoPrivate::isGroupChat to false

REVIEW: 105512

M  +7    -0    lib/adium-theme-header-info.cpp

http://commits.kde.org/telepathy-text-ui/29fc2479c6abcc49aa7b076cea919e88c79503b6