Created attachment 69648 [details] 1.2.1 v 1.2.2 combobox comparison With the update to oxygen-gtk2 1.2.2 comboboxes started to look really bad in Firefox. There appears to be no padding in the widget and the font overlaps the borders. I've attached a screenshot of 1.2.1/1.2.2 comparison.
@Ruslan this is likely a consequence of your "pixel" hunting. (will double check) One could set special settings for XUL applications inside oxygenqtsettings that (hopefully) overwrite your change from gtkrc (or alternatively put all related gtkrc entries in oxygenqtsettings) I can work on this if you don't have time to (but not before tomorrow)
In fact, the left one looks also far from perfect. And this is a firefox problem in that it doesn't do the same as GTK in handling themes. Of course, we might add yet another workaround for firefox, but I'd rather report this bug upstream and do nothing in oxygen-gtk. Especially because how it used to look (left screenshot) isn't what we want it to look like. PS In fact, GTK is rather bad toolkit to use its theming API. There are some problems, namely GTK setting ypad and xpad to 2 which leads to us unable to shrink some text-based widgets. And here firefox seems to set its own ypad to 0 and at the same time shrink the text widget even more.
@Ruslan well technically its a regression. Sure the first comboboxes don't look perfect, but surely enough the new ones look worse. I agree it is likely another firefox bug but 1/ firefox is likely the most used application that uses our style 2/ I doubt they give a damn about these kind of fixes. So I think its good to file a bug upstream, but I'd also really like to have this fixed before 1.2.3 (as you pointed out there are already many isXUL in the code, including in OxygenQtSettings iirc so no big deal) Possibly, by adding another "exception" we could make it look even better than in 1.2.1 Will work on it today.
PS: new comboboxes also look quite bad in libreoffice, but on the other hand since things are so fubared in libreoffice that I don't care as much as for firefox and company (thunderbird, to name one). In fact, to be honest, I am more sensitive to the regressions introduced by the shrinking than to the "improvement" added in regular gtk apps - since I dont use that many anyway). So that if it where up to me, I'd even revert the guilty change (possibly, the original padding introduced by me was to large precisely for this reason).
Also, still in firefox, the shrinking of the text entries makes the URL text entry look worse (around the icon on the left) Admiringly again, it was not perfect before either, but still ...
Git commit 482ef09be87f3974b14031288708922b36855847 by Hugo Pereira Da Costa. Committed on 16/03/2012 at 11:05. Pushed by hpereiradacosta into branch 'master'. moved settings of x/ypadding for GtkComboBox buttons from gtkrc to Oxygen::QtSettings. used different settings for XUL applications. M +0 -8 rc/gtkrc M +32 -17 src/oxygenqtsettings.cpp M +3 -0 src/oxygenqtsettings.h http://commits.kde.org/oxygen-gtk/482ef09be87f3974b14031288708922b36855847
that fixes it. Will backport to 1.2 after a couple of days testing (don't want more "regressions" in the stable branch)