Bug 295573 - Cannot expand directories in folder panel by double-clicking
Summary: Cannot expand directories in folder panel by double-clicking
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: panels: folders (show other bugs)
Version: 2.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-09 03:34 UTC by Jared B.
Modified: 2012-09-20 16:07 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jared B. 2012-03-09 03:34:36 UTC
Since Dolphin 2.0, directories are not expanded when double-clicked in the folder panel.  This makes navigating by double-clicking impossible to do in the folder panel.

For example, assume I have a directory named Documents under my home directory, and another directory named Music under my Documents directory.

Currently, if I double-click on Documents in the folder panel, the contents of the directory will appear in the browser pane, but the folder does not expand in the folder panel.  I need to either click the twisty next to Documents in order to expand it and see Music, or double click on Music in the browser pane in order to expand Documents in the folder panel.

What would be expected (and the previous behavior) is that, when I double-click on Documents in the folder panel, the contents of Documents is shown in the browser pane AND the Documents directory in the folder pane is expanded so I can see Music as well as any other subdirectories listed under it for faster/easier browsing.
Comment 1 leo_rockway 2012-07-07 20:04:10 UTC
I can confirm this behaviour is still present in KDE SC 4.9RC1.
Comment 2 Jared B. 2012-08-15 05:15:47 UTC
This is still an issue in 4.9.0 as well.  Has anyone had a chance to look at it?  This is a pretty clear regression from the 2.0/4.8 release, and while I know it's not a critical bug, it does hamper usability.  I was hoping this would've been addressed by 4.9.0.
Comment 3 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:18:33 UTC
Resetting assignee to default as per bug #305719
Comment 4 Emmanuel Pescosta 2012-09-18 18:50:39 UTC
Review-Request: https://git.reviewboard.kde.org/r/106497/
Comment 5 Emmanuel Pescosta 2012-09-20 16:01:11 UTC
Git commit 3cb15ca7a116bccdb6f60611d60f2839cf1f924b by Emmanuel Pescosta.
Committed on 20/09/2012 at 17:56.
Pushed by emmanuelp into branch 'KDE/4.9'.

Restore old behavior: Navigating by double-clicking in folder panel (Double-Click - show folder content and expand folder)
REVIEW: 106497
FIXED-IN: 4.9.2

M  +19   -0    dolphin/src/kitemviews/kitemlistcontroller.cpp
M  +10   -0    dolphin/src/kitemviews/kitemlistcontroller.h
M  +1    -0    dolphin/src/panels/folders/folderspanel.cpp

http://commits.kde.org/kde-baseapps/3cb15ca7a116bccdb6f60611d60f2839cf1f924b
Comment 6 Jared B. 2012-09-20 16:07:57 UTC
Yes!  Thanks, emmanuel099.  I actually tried testing your patch last night so I could give you some feedback, but couldn't get it to apply against stock 4.9.1.  I'm guessing some other changes had already been made to these components there were causing some conflicts.

Regardless, though, I'm thrilled to see this will be fixed in 4.9.2.  Great news.