Bug 294866 - Problematic gcry_check_version(GCRYPT_VERSION) check
Summary: Problematic gcry_check_version(GCRYPT_VERSION) check
Status: RESOLVED FIXED
Alias: None
Product: ktorrent
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: Joris Guisson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-26 14:28 UTC by Modestas Vainius
Modified: 2012-02-28 17:35 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Modestas Vainius 2012-02-26 14:28:43 UTC 
Hello,

gcry_check_version(GCRYPT_VERSION) check at src/util/functions.cpp:InitGCrypt() is problematic. It uses GCRYPT_VERSION macro which expands to gcrypt version at compile time and potentially overrides dependencies provided by higher level packaging tools. If a minimum gcrypt version is needed, it should either be hardcoded in the code, or better yet, provided and defined via CMakeLists.txt.

See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653400 for more information.
Comment 1 Joris Guisson 2012-02-28 17:34:49 UTC 
Git commit a23bafe9191e0dcbd5ae75335fd5d8e49bfda9ed by Joris Guisson.
Committed on 28/02/2012 at 18:34.
Pushed by guisson into branch 'master'.

Don't use the gcrypt version macro in it's version check

M  +1    -0    ChangeLog
M  +3    -3    src/util/functions.cpp

http://commits.kde.org/libktorrent/a23bafe9191e0dcbd5ae75335fd5d8e49bfda9ed
Comment 2 Joris Guisson 2012-02-28 17:35:41 UTC 
Git commit d285dad197ebab968df16885b30d40b2666a8ae9 by Joris Guisson.
Committed on 28/02/2012 at 18:34.
Pushed by guisson into branch '1.2'.

Backport to 1.2: Don't use the gcrypt version macro in it's version check

M  +1    -0    ChangeLog
M  +3    -3    src/util/functions.cpp

http://commits.kde.org/libktorrent/d285dad197ebab968df16885b30d40b2666a8ae9