Bug 293828 - filter brush applies to bounding rect of predefined brush tip
Summary: filter brush applies to bounding rect of predefined brush tip
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-11 10:38 UTC by Dmitry Kazakov
Modified: 2012-03-07 12:23 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot (297.70 KB, image/png)
2012-02-11 10:38 UTC, Dmitry Kazakov
Details
result of painting invert filter (289.65 KB, image/jpeg)
2012-02-29 14:54 UTC, Halla Rempt
Details
shows artefacts still happen (184.30 KB, image/jpeg)
2012-03-05 09:38 UTC, Halla Rempt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Kazakov 2012-02-11 10:38:32 UTC
Created attachment 68697 [details]
Screenshot

1) Select Filter Op
2) Select Predefined Brush mask
3) Select Invert filter 
4) Paint

You'll see black squares appearing randomly on a canvas.
Comment 1 Sven Langkamp 2012-02-12 19:00:21 UTC
Works here.
Comment 2 Halla Rempt 2012-02-13 10:35:14 UTC
Doesn't happen here eidter, but the effect is still quite strange, since on the first pass, the filter op seems to paint, only on the second pass in the same stroke the filter inverts.
Comment 3 Halla Rempt 2012-02-29 14:53:22 UTC
I can reproduce easily, but "black squares" is the wrong description: the filter applies to the entire bounding rect of the brush, not limited by the mask. See screenshot of painting invert with the a3 dirty spot brush.
Comment 4 Halla Rempt 2012-02-29 14:54:19 UTC
Created attachment 69181 [details]
result of painting invert filter
Comment 5 Dmitry Kazakov 2012-03-03 14:37:15 UTC
Git commit bafbe74c784b0c7da1a693fd86a50dd8ab3f016b by Dmitry Kazakov.
Committed on 03/03/2012 at 16:34.
Pushed by dkazakov into branch 'master'.

Fixed Pipe Brush mask generation

The wrong check was added due to non-obvious naming. Fixed both.

M  +6    -6    krita/plugins/paintops/libbrush/kis_imagepipe_brush.cpp

http://commits.kde.org/calligra/bafbe74c784b0c7da1a693fd86a50dd8ab3f016b
Comment 6 Halla Rempt 2012-03-05 09:37:24 UTC
Hm, no, this isn't fixed yet. See attachment.
Comment 7 Halla Rempt 2012-03-05 09:38:02 UTC
Created attachment 69298 [details]
shows artefacts still happen
Comment 8 Dmitry Kazakov 2012-03-07 12:15:14 UTC
This is a different bug:
https://bugs.kde.org/show_bug.cgi?id=295464
Comment 9 Dmitry Kazakov 2012-03-07 12:23:43 UTC
Git commit c5e3c44925b5479be15c13e22cc424600df36952 by Dmitry Kazakov.
Committed on 03/03/2012 at 16:34.
Pushed by dkazakov into branch 'calligra/2.4'.

Fixed Pipe Brush mask generation

The wrong check was added due to non-obvious naming. Fixed both.

M  +6    -6    krita/plugins/paintops/libbrush/kis_imagepipe_brush.cpp

http://commits.kde.org/calligra/c5e3c44925b5479be15c13e22cc424600df36952