Version: 2.0 (using KDE 4.8.0) OS: Linux When you drop a file on itself the status bar says "Cannot drop FOLDER on itself". Reproducible: Always Steps to Reproduce: - Actual Results: - Expected Results: - OS: Linux (x86_64) release 3.0.0-15-generic Compiler: gcc
Thanks for the bug report! @Peter: I've noticed that in Dolphin 1.x, a drop on a file (no matter if it's the same file or not) is interpreted as a drop in the folder containing the file. I think that this behavior is considered correct, right?
(To be precise, another user made me aware of what the 1.x behavior was by e-mail).
I forgot to mention that dropping a file on a *different* file actually crashes Dolphin (assert in KonqOperations::asyncDrop() because that function expects either a directory, a desktop file, or an executable as the drop target).
@Frank: > I forgot to mention that dropping a file on a > *different* file actually crashes Dolphin Ah, I introduced this regression - will try to fix it today. > I've noticed that in Dolphin 1.x, a drop on a file > (no matter if it's the same file or not) is interpreted > as a drop in the folder containing the > file. I think that this behavior is considered correct, right? Yes: Dropping above a no-directory-file should just drop it into the parent (that's why no hover-notification is done on those files when dragging; still of course there might be better ways to indicate this for the users)
Git commit 13d975a6d7ea6552202a13d0d324754a4247d730 by Peter Penz. Committed on 08/02/2012 at 15:16. Pushed by ppenz into branch 'KDE/4.8'. Drag and drop: Adjust destination if the item is no directory or desktop-file The URL of the view should be used as destination target if a dropping is not done above a directory or desktop-file. FIXED-IN: 4.8.1 M +1 -1 dolphin/src/kitemviews/kfileitemmodel.cpp M +1 -2 dolphin/src/panels/folders/folderspanel.cpp M +4 -1 dolphin/src/views/dolphinview.cpp M +5 -2 dolphin/src/views/draganddrophelper.cpp M +8 -6 dolphin/src/views/draganddrophelper.h http://commits.kde.org/kde-baseapps/13d975a6d7ea6552202a13d0d324754a4247d730
Git commit 89e2d6920a1e59a7df7c06eaf3c9da8eb32ae260 by Peter Penz. Committed on 08/02/2012 at 15:16. Pushed by ppenz into branch 'master'. Drag and drop: Adjust destination if the item is no directory or desktop-file The URL of the view should be used as destination target if a dropping is not done above a directory or desktop-file. FIXED-IN: 4.8.1 M +1 -1 dolphin/src/kitemviews/kfileitemmodel.cpp M +1 -2 dolphin/src/panels/folders/folderspanel.cpp M +4 -1 dolphin/src/views/dolphinview.cpp M +5 -2 dolphin/src/views/draganddrophelper.cpp M +8 -6 dolphin/src/views/draganddrophelper.h http://commits.kde.org/kde-baseapps/89e2d6920a1e59a7df7c06eaf3c9da8eb32ae260