Bug 292870 - confusing tabs options in the configuration dialog box of rekonq
Summary: confusing tabs options in the configuration dialog box of rekonq
Status: RESOLVED FIXED
Alias: None
Product: rekonq
Classification: Applications
Component: general (show other bugs)
Version: latest git snapshot
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Andrea Diamantini
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-30 14:50 UTC by sahinsureyya
Modified: 2012-01-30 15:56 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sahinsureyya 2012-01-30 14:50:17 UTC
Version:           latest git snapshot (using KDE 4.8.0) 
OS:                Linux

The options available in the tabs part of rekonq settings is confusing. I am trying to tweak the tab behaviour by using the rekonq settings dialog box but some of the options in the tabs part are behaving unexpectedly.

Reproducible: Always

Steps to Reproduce:
* Go to settings of the tabs "Configure rekonq..." menu item.
* Switch to the Tabs part. You will find out that the second option "Open links in new tab instead of new window." is not checked but still rekonq is showing this behaviour, e.g. it opens links in new tabs instead of new windows.
* If you check this item, you will find that it will reverse the behaviour, i.e. it will start opening links in new windows instead of new tabs.

Actual Results:  
Although the option "Open links in new tab instead of new window" is not checked in the settings of rekonq, it opens links in new tabs. If you check this option, then it behaves oppposite way, it opens links in new windows instead of tabs.

Additionally, the third option in the tabs setting, which says "Open external links in a new window" is a bit ambiguous, I couldn't figure out if this means the popup windows would open in a new window if I check this item or if it is related to the previous option.

Expected Results:  
I would expect that if the tabs setting option "Open links in new tab instead of new window" is checked, Rekonq would open links in new tabs instead of windows. Currently, it is behaving oppositely.
Comment 1 Andrea Diamantini 2012-01-30 15:32:58 UTC
No, they are not confusing: they are stupidly wrong :)
Fixing them asap. Thanks for noticing it...
Comment 2 Andrea Diamantini 2012-01-30 15:33:29 UTC
Git commit 255924e9a33ef1114d5d2d74d8496364db6f026b by Andrea Diamantini.
Committed on 30/01/2012 at 16:32.
Pushed by adjam into branch 'master'.

Fix settings tabs UI texts

M  +2    -2    src/settings/settings_tabs.ui

http://commits.kde.org/rekonq/255924e9a33ef1114d5d2d74d8496364db6f026b
Comment 3 sahinsureyya 2012-01-30 15:56:51 UTC
Thank you, I just updated rekonq and it is working as I would 
expect.