Bug 292202 - Vi override mappings are not preserved between restarts
Summary: Vi override mappings are not preserved between restarts
Status: RESOLVED FIXED
Alias: None
Product: kdevelop
Classification: Applications
Component: general (show other bugs)
Version: git master
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 4.2.3
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-22 15:44 UTC by Casey Link
Modified: 2012-10-28 21:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Patch to load KTextEditor config (433 bytes, patch)
2012-10-10 19:20 UTC, Simon St James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Casey Link 2012-01-22 15:44:52 UTC
Version:           git master (using KDE 4.7.4) 
OS:                Linux

Confirmed with milian and ehamberg on #kate

The config dialog is not being populated correctly.


Reproducible: Didn't try

Steps to Reproduce:
1. Add a vi override mapping in the config editor
2. close dialog
3. Confirm mapping saved: grep -i normal ~/.kde/share/config/kdeveloprc
4. Close kdevelop
5. repeat 3, still there
6. Open kdevelop, repeat 3, still there
7. Open config editor, repeat three, still 3
8. The vi mapping view is now empty
9. Cancel/Ok the dialog
Normal Mode Mapping Keys=
and
Normal Mode Mappings=

Actual Results:  
The vi override mappings are blanked out. 



Expected Results:  
Vi mappings should still be there.
Comment 1 Milian Wolff 2012-02-05 16:23:40 UTC
https://bugs.kde.org/293262 <-- I think this should be done for kdevelop as well
Comment 2 Simon St James 2012-09-09 09:26:28 UTC
It looks like they are written to the config file correctly (in KDevPlatform, shell/mainwindow_actions.cpp, "editor->writeConfig();
"), but KDevelop/ KDevPlatform never actually calls KateGlobal::readConfig, so they are never re-loaded (and are subsequently overwritten with blanks).
Comment 3 Simon St James 2012-10-10 19:20:58 UTC
Created attachment 74467 [details]
Patch to load KTextEditor config

I've been using the equivalent of the attached patch (against kdevplatform-4.3.1) for about a month or so, and it seems to work fine so far!
Comment 4 Olivier.jg 2012-10-28 21:30:05 UTC
Git commit 0e2de87776eb43642a52966c4608ef90c079e546 by Olivier JG, on behalf of Simon St James.
Committed on 28/10/2012 at 22:26.
Pushed by olivierjg into branch 'master'.

Restore editor config on load.

M  +1    -0    shell/partcontroller.cpp

http://commits.kde.org/kdevplatform/0e2de87776eb43642a52966c4608ef90c079e546