Created attachment 67975 [details] patch Version: unspecified (using Devel) OS: Solaris building kdegames 4.7.97 fails with the below error. This is because guessNumber in State::State in .h is const int while the .cpp uses just int. The Solaris Studio compiler is sensitive to this. Reproducible: Didn't try Steps to Reproduce: try building kdegames Actual Results: Linking CXX executable ksudoku cd /opt/test2/packages/BUILD/kdegames-4.7.97/build-kdegames-4.7.97/ksudoku/src && /opt/kde4/bin/cmake -E cmake_link_script CMakeFiles/ksudoku.dir/link.txt --verbose=1 ... file Undefined first referenced symbol in file State::State(QObject*,const QList<int>&,const int,const QVector<int>&,const QList<int>&,const QList<int>&) CMakeFiles/ksudoku.dir/generator/sudokuboard.o ld: fatal: symbol referencing errors. No output written to ksudoku Expected Results: builds ok Solaris 11, Solaris Studio 12.3
Thanks for the patch. I will commit it in a few days time, after the KDE SC 4.8 release, and will backport it into KDE SC 4.8.1, scheduled for 6 March.
SVN commit 1281833 by ianw: Related: bug 291896 Fix a const mismatch and allow compilation in Solaris Studio. M +1 -1 state.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1281833
SVN commit 1281834 by ianw: Related: bug 291896 Backport to 4.8.1. Fix a const mismatch and allow compilation in Solaris Studio. M +1 -1 state.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1281834