Bug 290491 - Shortcut collisions for selection tools' modes
Summary: Shortcut collisions for selection tools' modes
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-03 12:45 UTC by Hirato
Modified: 2012-03-03 07:30 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hirato 2012-01-03 12:45:59 UTC
Version:           svn trunk (using KDE 4.7.4) 
OS:                Linux

The selection tools define the shortcuts, R, T, A and S for changing the selection mode. Respectively they are meant to change the mode to replace, intersect, add and subtract.
It is possible that similar collisions exist for the other tools as well.

Reproducible: Always

Steps to Reproduce:
Select one of the selection tools, and press either R, T or S

Actual Results:  
R - Changes the current tool to the rectangle selection tool
T - no discernible effect
A - changes the selection mode to "add" 
S - summons a colour wheel (useless for this mode)

Expected Results:  
R - Changes the selection mode to "replace"
T - Changes the selection mode to "intersect"
A - Changes the selection mode to "add" 
S - Changes the selection mode to "subtract"
Comment 1 Halla Rempt 2012-01-21 11:00:27 UTC
Hi,

Thanks for the report. I've upgraded the severity of the report. We really should try to fix this in time for the 2.4 release.
Comment 2 Sven Langkamp 2012-01-23 17:03:45 UTC
Git commit 36a055f447b0d909503be091161862337ef96db8 by Sven Langkamp.
Committed on 23/01/2012 at 18:01.
Pushed by langkamp into branch 'master'.

use different shortcut as that is already used as shortcut for subtract

M  +1    -1    krita/plugins/tools/selectiontools/kis_tool_select_rectangular.h

http://commits.kde.org/calligra/36a055f447b0d909503be091161862337ef96db8
Comment 3 Sven Langkamp 2012-01-24 16:29:44 UTC
Git commit f90ba002fc6ca7fc096cb802baa74d9fe6e8755b by Sven Langkamp.
Committed on 24/01/2012 at 17:26.
Pushed by langkamp into branch 'master'.

cleanup shortcuts, avoid collision with selection tools

M  +3    -3    krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_container.cpp

http://commits.kde.org/calligra/f90ba002fc6ca7fc096cb802baa74d9fe6e8755b
Comment 4 Dmitry Kazakov 2012-03-03 07:30:50 UTC
Fixed in 2.4 RC1