Bug 288047 - Vertical alignment of text does not work properly for draw:custom-shape
Summary: Vertical alignment of text does not work properly for draw:custom-shape
Status: RESOLVED FIXED
Alias: None
Product: calligracommon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: LukasT
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-02 10:56 UTC by Matus Uzak
Modified: 2012-05-06 16:28 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
ODP test file created by Stage (3.93 KB, application/vnd.oasis.opendocument.presentation)
2011-12-02 10:56 UTC, Matus Uzak
Details
Test file displayed by ooimpress. (162.42 KB, image/png)
2011-12-02 10:56 UTC, Matus Uzak
Details
Test file displayed by Stage (155.73 KB, image/png)
2011-12-02 10:57 UTC, Matus Uzak
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matus Uzak 2011-12-02 10:56:13 UTC
Created attachment 66301 [details]
ODP test file created by Stage

Version:           unspecified
OS:                Linux

The support for draw:textarea-vertical-align does not work properly for draw:custom-shape elements. 

Reproducible: Didn't try

Steps to Reproduce:
1. Open the attached ODP test file in Stage.
2. There are two shapes on the slide.

Actual Results:  
Both shapes use the same graphic style, but the vertical alignment works only for the first one the draw:frame element. 

Expected Results:  
In both shapes the vertical alignment of text should work properly.
Comment 1 Matus Uzak 2011-12-02 10:56:47 UTC
Created attachment 66302 [details]
Test file displayed by ooimpress.
Comment 2 Matus Uzak 2011-12-02 10:57:09 UTC
Created attachment 66303 [details]
Test  file displayed by Stage
Comment 3 LukasT 2011-12-22 09:58:59 UTC
I will take a look.
Comment 4 Gopalakrishna Bhat 2012-05-06 16:28:03 UTC
Git commit 26092c58f9e3d7180048286af9c6186b2e1fdbae by Gopalakrishna Bhat A.
Committed on 06/05/2012 at 18:20.
Pushed by gopalakrishnabhat into branch 'master'.

We used to ignore the vertical and horizontal alignment for ToS. This patch fixes that issue.
Related: bug 284260
REVIEW: 104813

M  +2    -2    libs/flake/KoPathShape.cpp
M  +79   -0    libs/flake/KoTosContainer.cpp
M  +6    -0    libs/flake/KoTosContainer.h
M  +1    -0    libs/flake/KoTosContainer_p.h
M  +2    -2    plugins/pictureshape/PictureShape.cpp

http://commits.kde.org/calligra/26092c58f9e3d7180048286af9c6186b2e1fdbae