Bug 287562 - Accidently double-clicking before drawing a shape causes shape to be unable to be drawn
Summary: Accidently double-clicking before drawing a shape causes shape to be unable t...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 2.4-snapshots
Platform: Arch Linux Linux
: NOR grave
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-25 17:10 UTC by Travis
Modified: 2011-11-29 19:32 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Travis 2011-11-25 17:10:08 UTC
Version:           2.4-snapshots
OS:                Linux

In the recent Calligra Suite Betas, including Beta 4, I have been primarily using Krita. This particular issue is with the krita drawing functions for drawing rectangles, squares, circles, stars, and polygons. 

Here is what happens, bare with me as I try to explain this as best as possible please...

1.) I select a shape drawing tool... lets say the rectangle tool in this case, those this happens with any shape drawing tool. 

2.) If I click once I can simply draw the shape as desired. Awesome.

3.) But if I accidenly double or tripple click - ie... click too fast as I sometimes accidently do - I am no longer able to draw any shape on the layer. It seems that the layer itself becomes unalterable in any way. 

4.) To fix the issue I either have to save and restart krita or use the vector drawing brush (or any brush which causes a new layer such as a vector layer, or create a new layer, and then merge that layer with the affected layer. Once merged, the affected layer becomes usable again until I accidently trigger this "bug".

Reproducible: Always

Steps to Reproduce:
1.) Click a shape drawing tool - not the add shape tool - such as the rectangle, circle, star, polygon tool...

2.) Double or triple click - ie click to fast - where you intend to draw the shape

3.) Notice that now you are unable to draw on layer. 

Actual Results:  
Unable to draw on affected layer. 

Expected Results:  
SHould still be able to draw on affected layer, or should find that the layer is somehow locked but can be unlocked.

This is using an unmodified form of Krita, from the Caligra Suite Beta 3 and Beta 4, as provided by the Arch Linux distribution's "KDE Unstable" Repository. This is in the 64bit version of the OS. 

This only happens if my fingers get click crazy.
Comment 1 Bogdan Udrescu 2011-11-26 22:36:57 UTC
Can you provide a KDE version ?
Comment 2 Travis 2011-11-27 13:30:00 UTC
KDE version is 4.7.3. This was present in 4.7.2 as well.
Comment 3 Sven Langkamp 2011-11-29 19:32:51 UTC
Git commit f82f0e03c60e519f9e4c25e806340c86c97a6331 by Sven Langkamp.
Committed on 29/11/2011 at 20:29.
Pushed by langkamp into branch 'master'.

fix locking of tools, when the method returned before the the end reached the layer stays locked
using KisSystemLocker everywhere now to prevent such cases
BUG:287562

M  +1    -0    krita/plugins/tools/defaulttools/kis_tool_ellipse.cc
M  +2    -2    krita/plugins/tools/defaulttools/kis_tool_fill.cc
M  +2    -2    krita/plugins/tools/defaulttools/kis_tool_gradient.cc
M  +2    -2    krita/plugins/tools/defaulttools/kis_tool_path.cc
M  +2    -2    krita/plugins/tools/defaulttools/kis_tool_rectangle.cc
M  +2    -2    krita/plugins/tools/selectiontools/kis_tool_select_rectangular.cc
M  +3    -2    krita/plugins/tools/tool_star/kis_tool_star.cc
M  +2    -2    krita/plugins/tools/tool_transform2/kis_tool_transform.cc
M  +2    -2    krita/ui/tool/kis_tool_ellipse_base.cpp
M  +2    -2    krita/ui/tool/kis_tool_polyline_base.cpp

http://commits.kde.org/calligra/f82f0e03c60e519f9e4c25e806340c86c97a6331