Bug 286272 - linking against readline does not require linking against ncurses
Summary: linking against readline does not require linking against ncurses
Status: RESOLVED FIXED
Alias: None
Product: kalgebra
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-10 15:19 UTC by Colin Watson
Modified: 2011-11-10 15:45 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
stop trying to link directly against ncurses (1.56 KB, patch)
2011-11-10 15:19 UTC, Colin Watson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Watson 2011-11-10 15:19:28 UTC
Created attachment 65480 [details]
stop trying to link directly against ncurses

Version:           unspecified (using Devel) 
OS:                Linux

calgebra doesn't use libncurses directly, only libreadline.  The requirement for libncurses is an internal implementation detail of the readline library.  On current development versions of Debian and Ubuntu, libreadline no longer links against libncurses to avoid the difficulty with wide and non-wide versions of ncurses (http://enc.com.au/2011/09/ncurses-library-split/).

Here's a similar Debian bug by way of example: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=646146

I've attached a patch which drops the ncurses requirement.

Reproducible: Always

Steps to Reproduce:
Build on the current Ubuntu development release (precise) with libreadline-dev installed but without libncurses*-dev.

Actual Results:  
The build system claims that libreadline is not available.

Expected Results:  
The build system should not care about the lack of libncurses, since it can link against libreadline.
Comment 1 Aleix Pol 2011-11-10 15:24:18 UTC
Git commit 7c2cbb15d4bbb9b0719332a85edc5c0b698683c6 by Aleix Pol.
Committed on 10/11/2011 at 16:23.
Pushed by apol into branch 'master'.

Don't link calgebra against ncurses, apparently it's not needed anymore.

BUG: 286272

M  +1    -1    calgebra/CMakeLists.txt
M  +0    -1    cmake/FindReadline.cmake

http://commits.kde.org/analitza/7c2cbb15d4bbb9b0719332a85edc5c0b698683c6
Comment 2 Colin Watson 2011-11-10 15:39:01 UTC
Thanks - you seem to have missed a few bits of my patch against FindReadline.cmake, though?  It seems odd to keep on referring to NCURSES_LIBRARY after no longer running FIND_LIBRARY on it.
Comment 3 Aleix Pol 2011-11-10 15:45:39 UTC
Git commit 2e3629d9602c88de8177b4600d8aca372c84c877 by Aleix Pol.
Committed on 10/11/2011 at 16:44.
Pushed by apol into branch 'master'.

Forgot to remove the rest of the NCURSES variables' reads.

BUG: 286272

M  +4    -4    cmake/FindReadline.cmake

http://commits.kde.org/analitza/2e3629d9602c88de8177b4600d8aca372c84c877