Bug 285807 - Filters : auto loading of last settings at dialog opening. Not good behavior
Summary: Filters : auto loading of last settings at dialog opening. Not good behavior
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-05 11:04 UTC by David REVOY
Modified: 2011-11-05 20:54 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2011-11-05 11:04:39 UTC
Version:           svn trunk
OS:                Linux

When call a filter  ( ex: HSV adjustement  ) the dialog start by setting the sliders to the last used values. An unwanted behavior. 

Reproducible: Didn't try

Steps to Reproduce:
Go to the top menu 
- Open a picture
- Filter > Adjust > HSV Adjustement
- tweak a weird value on sliders, it will color your picture
- accept
- close Krita
- open it again
- Open a picture
- Filter > Adjust > HSV Adjustement 

Actual Results:  
Krita remember and propose the last value on opening the dialog. 

Expected Results:  
I prefer start by the 0 point ( all slider to 0 = no effect on the canvas ), then move the sliders to see the change.
For some Filters, 0 is not conveniant ( Blur / pixelise / effects ).
But a default settings is necessary on dialog opening. 


The "last used" setting is on the preset, if I need it anyway. 

Affect almost each Filters with preset possibility
Comment 1 Sven Langkamp 2011-11-05 13:15:55 UTC
There was another bug that said it should be exactly the other way around. So the auto loading is actually a feature.
Comment 2 David REVOY 2011-11-05 14:00:41 UTC
Why not load the last used settings on demand ( in the preset menu options, 'Last used' ) and propose to users a real 'default settings' ?
It would be way more logical on a workflow point of view. 

This other user who wanted this feature is surely from the time of old Krita 2.3 ; it's just for someone who want to save 1s in adjusting a series of photo because he don't know how to batch.

This color adjustement now are usefull for tweaking artworks, and need to be neutral at launch and let the user experience feedback while moving sliders and curves. Launching directly a 'last used preset' is like display a wrong solution each time.

At least, if the most of team don't agree with my point of view on this topic, can I ask a 'reset button'. I will press it all the time... but that's far faster than 'saving', 'open Gimp' and 'do my color correction'.
Comment 3 David REVOY 2011-11-05 14:27:53 UTC
I said 2 wrong things on the previous comment, sorry 
( can't find 'edit button' so I add this )

- "from the time of old Krita 2.3" wanted of course to do a references to older than 2.2 version when target wasn't for digital painting but for photomanipulation. 

- "can I ask a 'reset button'" , such a feature already exist : within the 2 presets 'Default' and 'Last Used' , 'Default' act like a reset. 
There is a bad Ui consistency : Filter at launch , launch the 'Last used' settings, but in the preset its displayed 'Default' label. User can't know by selecting 'Last Used' on the list, then reselect 'Default' the filter come back to default value.
Comment 4 animtim 2011-11-05 20:02:53 UTC
I agree on David's point of view about this, please confirm the bug.
Comment 5 Halla Rempt 2011-11-05 20:23:33 UTC
Snip of irc discussion:

21:04:19 < slangkamp> any opinions on bug 285807?
21:04:20 < bugbot> KDE bug 285807 in krita (usability) "Filters : auto loading of last settings at dialog opening  Not good behavior" [Normal,Unconfirmed] http://bugs.kde.org/285807
21:05:29 < dmitryK> LukasT: ok
21:05:51 < boud> slangkamp: well, not really much of an opinion; the current implementation is a bit unfinished.
21:07:05 -!- dmitryK [~dmitryK@178.217.108.14] has quit [Remote host closed the connection]
21:09:46 < boud> but in principle, I think we should look at what our users need: we don't cater to batch manipulation, so startng tools, filters etc. with default settings makes sense
21:09:59 < boud> a painter might want to adjust levels on his image, then paint, then adjust levels again
21:10:08 < boud> but he wants to start from zero the second time
21:11:23 < Animtim> yep, that's the point ;)
21:11:47 < boud> the current filter dialog was done before our focus
21:14:10 < slangkamp> shouldn't be hard to change that
21:14:20 < deevad> many thanks :) <3
Comment 6 Sven Langkamp 2011-11-05 20:54:40 UTC
Git commit 812dbd4cb29782c469176dd0bb18ca9f99ae61c7 by Sven Langkamp.
Committed on 05/11/2011 at 21:52.
Pushed by langkamp into branch 'master'.

disable auto loading of settings in filter dialog
BUG:285807

M  +3    -3    krita/image/kis_base_processor.cpp

http://commits.kde.org/calligra/812dbd4cb29782c469176dd0bb18ca9f99ae61c7