Bug 285562 - 8 keyboard layouts configured, message that only 4 are allowed.
Summary: 8 keyboard layouts configured, message that only 4 are allowed.
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_keyboard_layout (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Andriy Rysin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-02 13:48 UTC by Dotan Cohen
Modified: 2013-07-11 21:51 UTC (History)
3 users (show)

See Also:
Latest Commit: http://commits.kde.org/kde-workspace/7c599bae516c61365c4eda2be998c97594e3b1af
Version Fixed In: 4.11

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Dotan Cohen 2011-11-02 13:48:17 UTC 
In KDe 4.7.2 on Kubuntu 11.10 I can configure eight keyboard layouts. Trying to add any more pops up a message that only 4 keyboard layouts are allowed. Also, I can configure the "Main layout count" spinbox only up to 4.

Thanks.
Comment 1 Andriy Rysin 2011-11-03 00:22:44 UTC 
Confirmed. The question is shall I just fix the message (to say only up to 8 allowed) or you really need more than 8 keyboard layouts? I don't want to make it limitless but if there's a need for >8 I guess we could bump the limit a bit.
Comment 2 Dotan Cohen 2011-11-03 11:53:41 UTC 
I personally only need four, but a user recently contacted me who needs 5. I also remember a user once who wanted 6 layouts, for different family members. I would suggest updating the message to say "8" and also allowing the "Main Layout Count" go up to 8.

Alternatively, if you would like to mentor me this looks like the perfect easy bug to start learning KDE development. I have read the Getting Started/Build guide [1] but it assumes some prior knowledge. Investing some time in teaching me might save you some time in the future! I'm signing up for the kde-devel list now.

Thanks.

[1] http://techbase.kde.org/Getting_Started/Build/KDE4
Comment 3 Christoph Feck 2011-11-03 23:21:18 UTC 
Oh, you are right, this really is a junior job, and I am glad you are trying to look into it. When you have a working patch, please add it here or create a review request on https://git.reviewboard.kde.org/
Comment 4 Andriy Rysin 2011-11-11 04:38:16 UTC 
Dotan, I would definitely mentor if you're willing to work on this. You can either post your patch on review board as mentioned by Christoph or just send it to me directly.
Comment 5 Victor Polevoy 2013-07-02 20:42:29 UTC 
Git commit 7c599bae516c61365c4eda2be998c97594e3b1af by Victor Polevoy.
Committed on 02/07/2013 at 18:45.
Pushed by vpolevoy into branch 'master'.

Fix typo: 8 instead of 4 keyboard layouts when user trying to add more than 8 keyboard layouts in systemsettings/keyboard.

REVIEW: 110285

M  +2    -2    kcontrol/keyboard/kcm_keyboard_widget.cpp
M  +2    -0    kcontrol/keyboard/x11_helper.cpp
M  +2    -0    kcontrol/keyboard/x11_helper.h

http://commits.kde.org/kde-workspace/7c599bae516c61365c4eda2be998c97594e3b1af
Comment 6 Dotan Cohen 2013-07-03 04:47:08 UTC 
Thank you Victor!
Comment 7 Victor Polevoy 2013-07-03 06:32:02 UTC 
(In reply to comment #6)
> Thank you Victor!

Developing kde is pleasure for me.