Bug 285542 - Layout messed after delayed relayout when MIME types are determined
Summary: Layout messed after delayed relayout when MIME types are determined
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: icons mode (show other bugs)
Version: 1.99
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Peter Penz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-02 09:17 UTC by Christoph Feck
Modified: 2011-11-04 22:34 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 4.8.0


Attachments
Messed layout after reordering (79.15 KB, image/png)
2011-11-02 09:17 UTC, Christoph Feck
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2011-11-02 09:17:42 UTC
Created attachment 65146 [details]
Messed layout after reordering

When I select "Sort by Type", Dolphin first loads all items and displays them, then asyncronously determines MIME types, and when that is finished, it repositions items to follow the new order determined by types.

The second relayout seems only to change the positions, instead of sizes of the items, causing the layout to be messed up, see attachment.
Comment 1 Peter Penz 2011-11-02 09:32:28 UTC
Thanks for reporting issues like this, I was not aware about this yet. I've been aware about a layout-issue when turning on grouping in this usecase and I'm quite sure it has the same root-cause. I'll try to fix this during the next days...
Comment 2 Peter Penz 2011-11-04 22:34:56 UTC
Git commit 9869ea1f9e239379712e01bfba42e85a573eea16 by Peter Penz.
Committed on 04/11/2011 at 23:31.
Pushed by ppenz into branch 'master'.

Fix layout-issues when sorting by roles that are changed

When sorting is enabled for a role that gets changed e.g. because
a value like the MIME-type is determined asynchronously, then the
layout might get messed up.

slotItemsMoved() has been adjusted to invalidate the sizehint-cache
and to update the group-headers.

BUG: 285542
FIXED-IN: 4.8.0

M  +1    -1    dolphin/src/kitemviews/kfileitemmodel.cpp
M  +6    -4    dolphin/src/kitemviews/kitemlistsizehintresolver.cpp
M  +4    -1    dolphin/src/kitemviews/kitemlistsizehintresolver_p.h
M  +19   -9    dolphin/src/kitemviews/kitemlistview.cpp
M  +6    -0    dolphin/src/kitemviews/kitemmodelbase.h

http://commits.kde.org/kde-baseapps/9869ea1f9e239379712e01bfba42e85a573eea16