Version: 2.4 beta2 (Calligra 2.4 beta2) (using KDE 4.6.0) OS: Linux When openening a report in design view, when selecting a widget to place on the report, there is no visual indication for the selected widget (as for forms, there is). So there could be the same sunken effect as seen at the Form Design tab. Reproducible: Always Steps to Reproduce: Open report in Design view. Click any widget from the tab to be inserted on the report. Actual Results: There is no visual indication what widget is selected to be inserted. Expected Results: There should be a visual indication for the selected widget.
Git commit 9aa302e1fdd131c5ee7ae3f583367c8f49d6b31d by Jaroslaw Staniek. Committed on 01/12/2011 at 00:05. Pushed by staniek into branch 'master'. Fix bug: no indication of selected toolbox action for report element (should be bug #283888) BUG:283888 M +6 -3 kexi/doc/dev/CHANGELOG-Kexi-js http://commits.kde.org/calligra/9aa302e1fdd131c5ee7ae3f583367c8f49d6b31d
fixed in d130ba63ab62717565
Git commit 940fcedaa0ff174cebdafbb551e74a7f3004ee7c by Jaroslaw Staniek. Committed on 02/12/2011 at 19:48. Pushed by staniek into branch 'master'. Restore "Reports: fix bug: no indication of selected toolbox action for report element" +fix for Plan BUG:283888 CCMAIL:t.zachmann@zagge.de CCMAIL:boud@kde.org This reverts commit b424b352f682db0b31e68f1d8b35cf55f5c13693. M +2 -0 kexi/doc/dev/CHANGELOG-Kexi-js M +3 -1 kexi/plugins/reports/kexireportdesignview.cpp M +5 -1 kexi/plugins/reports/kexireportdesignview.h M +24 -5 kexi/plugins/reports/kexireportpart.cpp M +6 -4 kexi/plugins/reports/kexireportpart.h M +2 -3 libs/koreport/common/KoReportPluginManager.cpp M +1 -2 libs/koreport/common/KoReportPluginManager.h M +25 -21 libs/koreport/wrtembed/KoReportDesigner.cpp M +10 -9 libs/koreport/wrtembed/KoReportDesigner.h M +2 -1 plan/libs/ui/reports/reportview.cpp http://commits.kde.org/calligra/940fcedaa0ff174cebdafbb551e74a7f3004ee7c
In plan, the toolbar doesnt clear once an item is inserted. If this is unintentional, i will fix it tomorrow. Other than that, your fix is exactly what i had so far, except the name of the action group object ;)
@Adam it's indeed my overlook, feel free to fix :) As you have seen in the fix for Kexi Reports, clearing was not just oneliner.
Git commit e7cd3858e7596bb0245ab2496aacfb84aa7369b1 by Adam Pigg. Committed on 03/12/2011 at 12:02. Pushed by piggz into branch 'master'. Updated plan to properly uncheck report items once inserted BUG:283888 CCMAIL:staniek@kde.org CCMAIL:danders@get2net.dk M +17 -4 plan/libs/ui/reports/reportview.cpp M +7 -1 plan/libs/ui/reports/reportview_p.h http://commits.kde.org/calligra/e7cd3858e7596bb0245ab2496aacfb84aa7369b1