Bug 283869 - Feedback widget should be replaced by KMessageWidget
Summary: Feedback widget should be replaced by KMessageWidget
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: accounts-kcm (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: 0.4.0
Assignee: Telepathy Bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2011-10-12 16:18 UTC by David Edmundson
Modified: 2012-07-06 12:47 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Edmundson 2011-10-12 16:18:47 UTC
http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKMessageWidget.html

Both do the same thing, we made our own because this didn't exist at the time. Maintaining it would be a waste.
Comment 1 Dario Freddi 2011-12-13 21:14:06 UTC
Git commit ef8f205ffeb5748d4bf38a99d608cba50f928928 by Dario Freddi, on behalf of Dominik Cermak.
Committed on 13/12/2011 at 22:13.
Pushed by dafre into branch 'master'.

Replaced all occurrences of FeedbackWidget with KMessageWidget.
Also turned two Informative messages into Error messages to make it consistent.

Signed-off-by: Dario Freddi <dario.freddi@collabora.com>

CCMAIL:d.cermak@arcor.de
BUG:283869
REVIEW:103398

M  +5    -6    src/KCMTelepathyAccounts/account-edit-widget.cpp
M  +2    -2    src/KCMTelepathyAccounts/account-edit-widget.h
M  +8    -49   src/KCMTelepathyAccounts/feedback-widget.cpp
M  +5    -9    src/KCMTelepathyAccounts/feedback-widget.h
M  +2    -2    src/KCMTelepathyAccounts/parameter-edit-model.cpp
M  +2    -2    src/KCMTelepathyAccounts/parameter-edit-model.h
M  +6    -6    src/add-account-assistant.cpp
M  +2    -2    src/add-account-assistant.h
M  +2    -2    src/salut-details-dialog.cpp
M  +2    -2    src/salut-details-dialog.h
M  +4    -4    src/salut-enabler.cpp
M  +2    -2    src/salut-enabler.h

http://commits.kde.org/telepathy-accounts-kcm/ef8f205ffeb5748d4bf38a99d608cba50f928928