Bug 283086 - plasma workspace crashes on searching for specific apps
Summary: plasma workspace crashes on searching for specific apps
Status: RESOLVED FIXED
Alias: None
Product: Active
Classification: Plasma
Component: Plasma mobile shell (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: HI crash
Target Milestone: unscheduled
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-30 10:31 UTC by Robby Engelmann
Modified: 2011-11-10 13:25 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
crash report (3.99 KB, text/plain)
2011-10-20 13:34 UTC, Javier Llorente
Details
plasma-device crash (5.83 KB, text/plain)
2011-10-31 19:48 UTC, Javier Llorente
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robby Engelmann 2011-09-30 10:31:11 UTC
Version:           unspecified
OS:                Linux

i see the crash when i search for 'yast' or 'system' in the search field of the upper applist or when i try to add for example yast as an ressource

Reproducible: Didn't try

Steps to Reproduce:
search as described above

Actual Results:  
crash

Expected Results:  
no crash
Comment 1 Robby Engelmann 2011-09-30 10:52:20 UTC
as i could not change the entries of the list-fields here in the bugtracker using active browser, here two additions:
reproducibility: everytime
priority: crash
Comment 2 Javier Llorente 2011-10-20 13:33:07 UTC
I typed in "Images" on the search field of the application grid and plasma-device crashed. Before crashing, I saw some Nepomuk icons next to the "Images" icon. When the peek area was back, I couldn't get back online; there was an X icon instead of the wifi one.
Note: I couldn't reproduce this bug always.
Verified on 2011-10-16-16-48-meego-plasma-active-testing-USB-live.iso
Comment 3 Javier Llorente 2011-10-20 13:34:16 UTC
Created attachment 64735 [details]
crash report
Comment 4 Javier Llorente 2011-10-31 19:48:00 UTC
Created attachment 65089 [details]
plasma-device crash

Just typing "sys" makes it crash. Tested on 2011-10-27-21-59-basyskom-plasma-active-testing-meego-usb-live.iso + latest updates from today.
Comment 5 Aaron J. Seigo 2011-10-31 21:36:33 UTC
#19 0xaf92c360 in LightDMDBus (this=0xcb16d98) at ../../../libs/kworkspace/kdisplaymanager.cpp:95

seriously, LightDM? that seems very odd. in any case, it's crashing on _creating_ the Session runner. that looks highly suspicious and like some sort of build issue.

in the other crash it's asking for mimeDataForMatch which is VERY odd since that should ONLY be used for things like drag and drop of items. there is no need to call that at all for just general searchs, so perhaps the new model is doing something odd there?
Comment 6 Aaron J. Seigo 2011-11-01 10:28:08 UTC
Git commit b2d71803a0c71615df99265200c28e670897d26b by Aaron Seigo.
Committed on 01/11/2011 at 11:27.
Pushed by aseigo into branch 'master'.

don't bother detecting for lightdm if the XDG_SEATH_PATH env var isn't set

may be one cause of crashing for some people in the sessions Runner plugin
CCBUG:283086

M  +1    -1    libs/kworkspace/kdisplaymanager.cpp

http://commits.kde.org/kde-workspace/b2d71803a0c71615df99265200c28e670897d26b
Comment 7 Christoph Feck 2011-11-01 11:27:46 UTC
Javier, please do not mix different backtraces in the same bug report. Comment #4 is bug 285125.
Comment 8 Javier Llorente 2011-11-01 12:34:23 UTC
(In reply to comment #7)
> Javier, please do not mix different backtraces in the same bug report. Comment
> #4 is bug 285125.

The last crash was triggered by doing the same thing as before (typing an app name in the application grid's search field), that's why I included it. But you're right, they are different. Sorry for mixing it up.
Comment 9 Aaron J. Seigo 2011-11-01 14:12:30 UTC
Git commit 50b11f7af4acd4f20f9fbf662bc991b4fd95332b by Aaron Seigo.
Committed on 01/11/2011 at 11:27.
Pushed by aseigo into branch 'KDE/4.7'.

don't bother detecting for lightdm if the XDG_SEATH_PATH env var isn't set

may be one cause of crashing for some people in the sessions Runner plugin
CCBUG:283086

M  +1    -1    libs/kworkspace/kdisplaymanager.cpp

http://commits.kde.org/kde-workspace/50b11f7af4acd4f20f9fbf662bc991b4fd95332b
Comment 10 Aaron J. Seigo 2011-11-01 14:16:21 UTC
Git commit 2f19a1c01ec94adc9f18e7a92fd3441416e0572f by Aaron Seigo.
Committed on 01/11/2011 at 15:14.
Pushed by aseigo into branch 'master'.

ensure no allocations (iterator and ref usage) if what was allocated is cheap

and as we have the match, just pass that directly to RunnerManager rather than the ID ...
... since it just uses the ID to find the Match again!

CCBUG:283086

M  +7    -8    dataengines/runner/runnersource.cpp

http://commits.kde.org/plasma-mobile/2f19a1c01ec94adc9f18e7a92fd3441416e0572f
Comment 11 Javier Llorente 2011-11-10 13:25:06 UTC
Already fixed on Project:KDE:Devel.