Bug 282466 - Support new CSS3 units
Summary: Support new CSS3 units
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: syntax (show other bugs)
Version: unspecified
Platform: Debian unstable Linux
: NOR minor
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-21 09:40 UTC by Vincent Ricard
Modified: 2011-10-02 11:03 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Adding CSS3 units (735 bytes, patch)
2011-09-27 08:27 UTC, Vincent Ricard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Ricard 2011-09-21 09:40:51 UTC
Version:           unspecified (using KDE 4.6.5) 
OS:                Linux

Hi,

I'm using kate to edit my CSS files, and i would be nice to support new CSS3 unit like 'rem'.

The specification can be found here (chpaters 'Distance Units: the ‘<length>’ type' and 'Other Units': http://www.w3.org/TR/css3-values/

Cheers,

PS: i can't send a patch, i didn't find the css.xml file in the new git repos. i didn't compile kde since a while.

Reproducible: Always

Steps to Reproduce:
enter this CSS source:

.field {
  margin: 1px;
  margin: 1rem;
}


Actual Results:  
The 'rem' unit is not highlighted as 'px' is.

Expected Results:  
Same highlighting for 'rem' and 'px' unit.
Comment 1 Dominik Haumann 2011-09-22 06:48:10 UTC
Build kate according to http://kate-editor.org/get-it/
css.xml is in part/syntax/data/css.xml
Comment 2 Vincent Ricard 2011-09-27 08:27:03 UTC
Created attachment 64004 [details]
Adding CSS3 units

Thanks for the link.

I added the following units: ch, rem, vw, vh, vm, turn.
Comment 3 Christoph Cullmann 2011-10-02 11:02:36 UTC
Git commit e50c493e1b8eef3eab683338b769d7c11cf1171b by Christoph Cullmann.
Committed on 02/10/2011 at 13:02.
Pushed by cullmann into branch 'master'.

Support new CSS3 units
patch by Vincent Ricard
BUG: 282466

M  +1    -1    part/syntax/data/css.xml

http://commits.kde.org/kate/e50c493e1b8eef3eab683338b769d7c11cf1171b
Comment 4 Christoph Cullmann 2011-10-02 11:03:20 UTC
Git commit 997641a214c03c9744a120759c890248a0eb58fc by Christoph Cullmann.
Committed on 02/10/2011 at 13:03.
Pushed by cullmann into branch 'master'.

inc version number of XML
BUG: 282466

M  +1    -1    part/syntax/data/css.xml

http://commits.kde.org/kate/997641a214c03c9744a120759c890248a0eb58fc