281688 – Use more unique names for the #ifndef #define... #endif pattern in public header files

Bug 281688 - Use more unique names for the #ifndef #define... #endif pattern in public header files

Summary: Use more unique names for the #ifndef #define... #endif pattern in public hea...

Status:	RESOLVED FIXED

Alias:	None

Product:	kdevplatform
Classification:	Developer tools
Component:	general (show other bugs)
Version:	git master
Platform:	Compiled Sources Linux

Importance:	HI wishlist
Target Milestone:	1.2.3
Assignee:	kdevelop-bugs-null

URL:
Keywords:	junior-jobs

Depends on:
Blocks:

Reported:	2011-09-09 13:33 UTC by Sven Brauch
Modified:	2013-04-26 23:52 UTC (History)
CC List:	2 users (show)

See Also:
Latest Commit:	http://commits.kde.org/kdevplatform/156fb9e5c615346ff9ecee3632c8ff8314825a79
Version Fixed In:

Attachments
clean headers guards naming (68.59 KB, patch) 2013-03-25 22:30 UTC, Laurent Navet	Details
prefix all plugins header guards with PLUGIN_ (140.44 KB, patch) 2013-03-25 22:31 UTC, Laurent Navet	Details
add KDEVPLATFORM_ to all headers guard (436.20 KB, patch) 2013-03-25 22:34 UTC, Laurent Navet	Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.

Description Sven Brauch 2011-09-09 13:33:06 UTC

Version:           git master (using KDE 4.7.0) 
OS:                Linux

As an example, the KDevelop FunctionDeclaration header (language/duchain/functiondeclaration.h) uses
#ifndef FUNCTIONDECLARATION_H
#define FUNCTIONDECLARATION_H
...
#endif

If you want to have your own FunctionDeclaration in a plugin, which is usually also called FunctionDeclaration (it's like this in most of the plugins) you have to remember using a different name than FUNCTIONDECLARATION_H, otherwise you'll run into weird compiler errors which are really hard to debug. The KDevPlatform header names should be prefixed with KDEVPLATFORM_, so no confusion can occur.

Reproducible: Always

Steps to Reproduce:
...


Expected Results:  
...

Comment 1 Aleix Pol 2011-09-12 02:43:34 UTC

I've run into this problem as well... +1

Comment 2 Andreas Pakulat 2013-03-21 11:22:59 UTC

Well, you should be using something specific to your plugin as well, i.e. I'd consider this same bug to apply to any plugin using something generic like that as a header guard.

Ideally one would use <projectname>_<relative_path_of_header_in_project>_<headername> where the relative path is split at the '/' and those are replaced with _.

Comment 3 Laurent Navet 2013-03-25 22:30:19 UTC

Created attachment 78385 [details]
clean headers guards naming

Comment 4 Laurent Navet 2013-03-25 22:31:25 UTC

Created attachment 78386 [details]
prefix all plugins header guards with PLUGIN_

Comment 5 Laurent Navet 2013-03-25 22:34:04 UTC

Created attachment 78387 [details]
add KDEVPLATFORM_ to all headers guard

these 3 patchs need to be applied in order.
builds ok,

Comment 6 Laurent Navet 2013-03-27 13:39:37 UTC

posted on reviewboard : https://git.reviewboard.kde.org/r/109763/

Comment 7 Sven Brauch 2013-04-26 23:52:25 UTC

Git commit 156fb9e5c615346ff9ecee3632c8ff8314825a79 by Sven Brauch, on behalf of Laurent Navet.
Committed on 27/04/2013 at 01:41.
Pushed by brauch into branch 'master'.

clean headers guards naming scheme

REVIEW:109763

A  +13   -0    cleanup_includeguards.sh
M  +2    -2    debugger/breakpoint/breakpoint.h
M  +3    -3    debugger/breakpoint/breakpointdetails.h
M  +2    -2    debugger/breakpoint/breakpointmodel.h
M  +3    -3    debugger/breakpoint/breakpointwidget.h
M  +2    -2    debugger/framestack/framestackmodel.h
M  +3    -3    debugger/framestack/framestackwidget.h
M  +3    -3    debugger/interfaces/ibreakpointcontroller.h
M  +2    -2    debugger/interfaces/idebugsession.h
M  +2    -2    debugger/interfaces/iframestackmodel.h
M  +2    -2    debugger/interfaces/ivariablecontroller.h
M  +2    -2    debugger/util/pathmappings.h
M  +2    -2    debugger/util/treeitem.h
M  +2    -2    debugger/util/treemodel.h
M  +2    -2    debugger/util/treeview.h
M  +2    -2    debugger/variable/variablecollection.h
M  +2    -2    debugger/variable/variabletooltip.h
M  +2    -2    debugger/variable/variablewidget.h
M  +2    -2    documentation/documentationexport.h
M  +3    -3    documentation/documentationfindwidget.h
M  +3    -3    documentation/documentationview.h
M  +3    -3    documentation/standarddocumentationview.h
M  +2    -2    interfaces/context.h
M  +2    -2    interfaces/contextmenuextension.h
M  +2    -2    interfaces/foregroundlock.h
M  +3    -3    interfaces/iassistant.h
M  +2    -2    interfaces/ibuddydocumentfinder.h
M  +2    -2    interfaces/icompletionsettings.h
M  +2    -2    interfaces/icore.h
M  +2    -2    interfaces/idebugcontroller.h
M  +2    -2    interfaces/idocument.h
M  +2    -2    interfaces/idocumentation.h
M  +2    -2    interfaces/idocumentationcontroller.h
M  +2    -2    interfaces/idocumentationprovider.h
M  +2    -2    interfaces/idocumentationproviderprovider.h
M  +2    -2    interfaces/idocumentcontroller.h
M  +2    -2    interfaces/ilanguage.h
M  +2    -2    interfaces/ilanguagecheck.h
M  +2    -2    interfaces/ilanguagecheckprovider.h
M  +2    -2    interfaces/ilanguagecontroller.h
M  +2    -2    interfaces/ilaunchconfiguration.h
M  +2    -2    interfaces/ilauncher.h
M  +2    -2    interfaces/ilaunchmode.h
M  +2    -2    interfaces/interfacesexport.h
M  +2    -2    interfaces/ipartcontroller.h
M  +2    -2    interfaces/ipatchdocument.h
M  +2    -2    interfaces/ipatchexporter.h
M  +3    -3    interfaces/ipatchsource.h
M  +2    -2    interfaces/iplugin.h
M  +2    -2    interfaces/iplugincontroller.h
M  +2    -2    interfaces/iproject.h
M  +2    -2    interfaces/iprojectcontroller.h
M  +2    -2    interfaces/iprojectprovider.h
M  +3    -3    interfaces/iruncontroller.h
M  +3    -3    interfaces/iselectioncontroller.h
M  +2    -2    interfaces/isession.h
M  +3    -3    interfaces/isourceformatter.h
M  +3    -3    interfaces/isourceformattercontroller.h
M  +2    -2    interfaces/istatus.h
M  +3    -3    interfaces/itemplateprovider.h
M  +3    -3    interfaces/itestcontroller.h
M  +3    -3    interfaces/itestsuite.h
M  +2    -2    interfaces/iuicontroller.h
M  +2    -2    interfaces/launchconfigurationpage.h
M  +2    -2    interfaces/launchconfigurationtype.h
M  +3    -3    interfaces/tests/test_foregroundlock.h
M  +2    -2    language/backgroundparser/backgroundparser.h
M  +2    -2    language/backgroundparser/documentchangetracker.h
M  +2    -2    language/backgroundparser/parsejob.h
M  +3    -3    language/backgroundparser/parseprojectjob.h
M  +3    -3    language/backgroundparser/parserdependencypolicy.h
M  +3    -3    language/backgroundparser/tests/test_backgroundparser.h
M  +2    -2    language/backgroundparser/tests/testlanguagesupport.h
M  +2    -2    language/backgroundparser/tests/testparsejob.h
M  +2    -2    language/backgroundparser/urlparselock.h
M  +2    -2    language/checks/controlflowgraph.h
M  +3    -3    language/checks/controlflownode.h
M  +2    -2    language/checks/dataaccess.h
M  +2    -2    language/checks/dataaccessrepository.h
M  +3    -3    language/codecompletion/abstractincludefilecompletionitem.h
M  +2    -2    language/codecompletion/codecompletion.h
M  +2    -2    language/codecompletion/codecompletioncontext.h
M  +2    -2    language/codecompletion/codecompletionhelper.h
M  +2    -2    language/codecompletion/codecompletionitem.h
M  +3    -3    language/codecompletion/codecompletionitemgrouper.h
M  +2    -2    language/codecompletion/codecompletionmodel.h
M  +3    -3    language/codecompletion/codecompletiontesthelper.h
M  +3    -3    language/codecompletion/codecompletionworker.h
M  +2    -2    language/codecompletion/normaldeclarationcompletionitem.h
M  +2    -2    language/codegen/applychangeswidget.h
M  +3    -3    language/codegen/archivetemplateloader.h
M  +3    -3    language/codegen/astchangeset.h
M  +3    -3    language/codegen/codedescription.h
M  +3    -3    language/codegen/codedescriptionmetatypes.h
M  +3    -3    language/codegen/codegenerator.h
M  +2    -2    language/codegen/coderepresentation.h
M  +2    -2    language/codegen/documentchangeset.h
M  +3    -3    language/codegen/duchainchangeset.h
M  +3    -3    language/codegen/komparesupport.h
M  +3    -3    language/codegen/sourcefiletemplate.h
M  +3    -3    language/codegen/templateclassgenerator.h
M  +3    -3    language/codegen/templateengine.h
M  +3    -3    language/codegen/templateengine_p.h
M  +3    -3    language/codegen/templaterenderer.h
M  +3    -3    language/codegen/templatesmodel.h
M  +3    -3    language/codegen/tests/expected/classname.h
M  +3    -3    language/codegen/tests/test_templateclassgenerator.h
M  +3    -3    language/codegen/tests/test_templaterenderer.h
M  +3    -3    language/codegen/tests/test_templatesmodel.h
M  +3    -3    language/codegen/utilities.h
M  +3    -3    language/duchain/abstractfunctiondeclaration.h
M  +3    -3    language/duchain/aliasdeclaration.h
M  +2    -2    language/duchain/appendedlist.h
M  +2    -2    language/duchain/appendedlist_static.h
M  +2    -2    language/duchain/builders/abstractcontextbuilder.h
M  +3    -3    language/duchain/builders/abstractdeclarationbuilder.h
M  +3    -3    language/duchain/builders/abstracttypebuilder.h
M  +3    -3    language/duchain/builders/abstractusebuilder.h
M  +3    -3    language/duchain/classdeclaration.h
M  +3    -3    language/duchain/classfunctiondeclaration.h
M  +3    -3    language/duchain/classmemberdeclaration.h
M  +2    -2    language/duchain/classmemberdeclarationdata.h
M  +2    -2    language/duchain/codemodel.h
M  +3    -3    language/duchain/declaration.h
M  +2    -2    language/duchain/declarationdata.h
M  +2    -2    language/duchain/declarationid.h
M  +2    -2    language/duchain/definitions.h
M  +3    -3    language/duchain/duchain.h
M  +3    -3    language/duchain/duchainbase.h
M  +3    -3    language/duchain/duchainlock.h
M  +3    -3    language/duchain/duchainobserver.h
M  +2    -2    language/duchain/duchainpointer.h
M  +2    -2    language/duchain/duchainregister.h
M  +3    -3    language/duchain/duchainutils.h
M  +3    -3    language/duchain/ducontext.h
M  +3    -3    language/duchain/dumpchain.h
M  +3    -3    language/duchain/dumpdotgraph.h
M  +3    -3    language/duchain/forwarddeclaration.h
M  +3    -3    language/duchain/functiondeclaration.h
M  +2    -2    language/duchain/functiondefinition.h
M  +3    -3    language/duchain/identifier.h
M  +2    -2    language/duchain/importers.h
M  +3    -3    language/duchain/indexeddeclaration.h
M  +3    -3    language/duchain/indexedducontext.h
M  +2    -2    language/duchain/indexedstring.h
M  +3    -3    language/duchain/indexedtopducontext.h
M  +3    -3    language/duchain/instantiationinformation.h
M  +3    -3    language/duchain/localindexeddeclaration.h
M  +3    -3    language/duchain/localindexedducontext.h
M  +3    -3    language/duchain/namespacealiasdeclaration.h
M  +2    -2    language/duchain/navigation/abstractdeclarationnavigationcontext.h
M  +3    -3    language/duchain/navigation/abstractincludenavigationcontext.h
M  +2    -2    language/duchain/navigation/abstractnavigationcontext.h
M  +2    -2    language/duchain/navigation/abstractnavigationwidget.h
M  +2    -2    language/duchain/navigation/navigationaction.h
M  +3    -3    language/duchain/navigation/problemnavigationcontext.h
M  +2    -2    language/duchain/navigation/usescollector.h
M  +2    -2    language/duchain/navigation/usesnavigationcontext.h
M  +2    -2    language/duchain/navigation/useswidget.h
M  +2    -2    language/duchain/parsingenvironment.h
M  +2    -2    language/duchain/persistentsetmap.h
M  +2    -2    language/duchain/persistentsymboltable.h
M  +2    -2    language/duchain/referencecounting.h
M  +2    -2    language/duchain/repositories/itemrepository.h
M  +2    -2    language/duchain/repositories/stringrepository.h
M  +2    -2    language/duchain/repositories/typerepository.h
M  +2    -2    language/duchain/specializationstore.h
M  +3    -3    language/duchain/tests/benchhashes.h
M  +3    -3    language/duchain/tests/benchmarks.h
M  +3    -3    language/duchain/tests/test_duchain.h
M  +3    -3    language/duchain/topducontext.h
M  +2    -2    language/duchain/topducontextdata.h
M  +2    -2    language/duchain/topducontextdynamicdata.h
M  +3    -3    language/duchain/topducontextutils.h
M  +2    -2    language/duchain/types/abstracttype.h
M  +2    -2    language/duchain/types/alltypes.h
M  +3    -3    language/duchain/types/arraytype.h
M  +3    -3    language/duchain/types/constantintegraltype.h
M  +2    -2    language/duchain/types/delayedtype.h
M  +3    -3    language/duchain/types/enumerationtype.h
M  +3    -3    language/duchain/types/enumeratortype.h
M  +2    -2    language/duchain/types/functiontype.h
M  +2    -2    language/duchain/types/identifiedtype.h
M  +2    -2    language/duchain/types/indexedtype.h
M  +2    -2    language/duchain/types/integraltype.h
M  +2    -2    language/duchain/types/pointertype.h
M  +3    -3    language/duchain/types/referencetype.h
M  +2    -2    language/duchain/types/structuretype.h
M  +3    -3    language/duchain/types/typealiastype.h
M  +2    -2    language/duchain/types/typepointer.h
M  +2    -2    language/duchain/types/typeregister.h
M  +3    -3    language/duchain/types/typesystem.h
M  +2    -2    language/duchain/types/typesystemdata.h
M  +2    -2    language/duchain/types/typeutils.h
M  +3    -3    language/duchain/types/unsuretype.h
M  +3    -3    language/duchain/use.h
M  +3    -3    language/duchain/useconditioneddeclaration.h
M  +2    -2    language/duchain/uses.h
M  +3    -3    language/duchain/waitforupdate.h
M  +2    -2    language/editor/cursorinrevision.h
M  +3    -3    language/editor/documentcursor.h
M  +3    -3    language/editor/documentrange.h
M  +3    -3    language/editor/editorintegratorstatic.h
M  +2    -2    language/editor/modificationrevision.h
M  +3    -3    language/editor/modificationrevisionset.h
M  +3    -3    language/editor/persistentmovingrange.h
M  +3    -3    language/editor/persistentmovingrangeprivate.h
M  +2    -2    language/editor/rangeinrevision.h
M  +2    -2    language/editor/simplecursor.h
M  +2    -2    language/editor/simplerange.h
M  +2    -2    language/highlighting/codehighlighting.h
M  +3    -3    language/highlighting/colorcache.h
M  +3    -3    language/highlighting/configurablecolors.h
M  +3    -3    language/highlighting/tests/test_highlighting.h
M  +2    -2    language/interfaces/codecontext.h
M  +2    -2    language/interfaces/editorcontext.h
M  +3    -3    language/interfaces/iastcontainer.h
M  +2    -2    language/interfaces/icodecompletion.h
M  +3    -3    language/interfaces/icodehighlighting.h
M  +3    -3    language/interfaces/icontextbrowser.h
M  +3    -3    language/interfaces/icreateclasshelper.h
M  +2    -2    language/interfaces/ilanguagesupport.h
M  +3    -3    language/interfaces/iproblem.h
M  +3    -3    language/interfaces/iquickopen.h
M  +2    -2    language/interfaces/quickopendataprovider.h
M  +2    -2    language/interfaces/quickopenfilter.h
M  +2    -2    language/util/basicsetrepository.h
M  +3    -3    language/util/debuglanguageparserhelper.h
M  +3    -3    language/util/includeitem.h
M  +3    -3    language/util/kdevhash.h
M  +3    -3    language/util/navigationtooltip.h
M  +2    -2    language/util/setrepository.h
M  +3    -3    outputview/filtereditem.h
M  +3    -3    outputview/ifilterstrategy.h
M  +2    -2    outputview/ioutputview.h
M  +2    -2    outputview/ioutputviewmodel.h
M  +2    -2    outputview/outputdelegate.h
M  +3    -3    outputview/outputexecutejob.h
M  +3    -3    outputview/outputfilteringstrategies.h
M  +2    -2    outputview/outputformats.h
M  +2    -2    outputview/outputjob.h
M  +2    -2    outputview/outputmodel.h
M  +2    -2    outputview/outputviewexport.h
M  +3    -3    outputview/tests/filteringstrategytest.h
M  +3    -3    outputview/tests/outputmodeltest.h
M  +2    -2    outputview/tests/testlinebuilderfunctions.h
M  +3    -3    plugins/appwizard/appwizardpagewidget.h
M  +2    -2    plugins/appwizard/projectvcspage.h
M  +2    -2    plugins/classbrowser/allclassesfolder.h
M  +3    -3    plugins/classbrowser/classbrowserplugin.h
M  +2    -2    plugins/classbrowser/classmodel.h
M  +2    -2    plugins/classbrowser/classmodelnode.h
M  +2    -2    plugins/classbrowser/classmodelnodescontroller.h
M  +2    -2    plugins/classbrowser/classtree.h
M  +3    -3    plugins/classbrowser/classwidget.h
M  +3    -3    plugins/classbrowser/documentclassesfolder.h
M  +3    -3    plugins/classbrowser/projectfolder.h
M  +3    -3    plugins/codeutils/codeutilsplugin.h
M  +3    -3    plugins/codeutils/tests/expected/testname.h
M  +3    -3    plugins/codeutils/tests/testgenerationtest.h
M  +2    -2    plugins/contextbrowser/browsemanager.h
M  +3    -3    plugins/contextbrowser/contextbrowser.h
M  +2    -2    plugins/contextbrowser/contextbrowserview.h
M  +2    -2    plugins/cvs/checkoutdialog.h
M  +2    -2    plugins/cvs/commitdialog.h
M  +2    -2    plugins/cvs/cvsannotatejob.h
M  +2    -2    plugins/cvs/cvsdiffjob.h
M  +2    -2    plugins/cvs/cvsgenericoutputview.h
M  +2    -2    plugins/cvs/cvsjob.h
M  +2    -2    plugins/cvs/cvslogjob.h
M  +2    -2    plugins/cvs/cvsmainview.h
M  +2    -2    plugins/cvs/cvsplugin.h
M  +2    -2    plugins/cvs/cvsproxy.h
M  +2    -2    plugins/cvs/cvsstatusjob.h
M  +2    -2    plugins/cvs/editorsview.h
M  +2    -2    plugins/cvs/importdialog.h
M  +2    -2    plugins/cvs/importmetadatawidget.h
M  +2    -2    plugins/cvs/tests/cvstest.h
M  +3    -3    plugins/dashboard/appletselector.h
M  +2    -2    plugins/dashboard/dashboard.h
M  +3    -3    plugins/dashboard/dashboardcorona.h
M  +2    -2    plugins/dashboard/dashboarddataengine.h
M  +3    -3    plugins/dashboard/dashboarddocument.h
M  +3    -3    plugins/dashboard/dashboardpluginloader.h
M  +3    -3    plugins/dashboard/dashboardview.h
M  +3    -3    plugins/dashboard/declarative/icoreobject.h
M  +3    -3    plugins/dashboard/declarative/kdevelopdashboarddeclarativeplugin.h
M  +3    -3    plugins/dashboard/kdevprojectdashboard.h
M  +2    -2    plugins/documentswitcher/documentswitcherplugin.h
M  +3    -3    plugins/documentswitcher/documentswitchertreeview.h
M  +3    -3    plugins/documentview/kdevdocumentmodel.h
M  +3    -3    plugins/documentview/kdevdocumentselection.h
M  +3    -3    plugins/documentview/kdevdocumentview.h
M  +3    -3    plugins/documentview/kdevdocumentviewdelegate.h
M  +2    -2    plugins/documentview/kdevdocumentviewplugin.h
M  +2    -2    plugins/documentview/settings/preferences.h
M  +3    -3    plugins/execute/executeplugin.h
M  +2    -2    plugins/execute/iexecuteplugin.h
M  +2    -2    plugins/execute/nativeappconfig.h
M  +2    -2    plugins/execute/nativeappjob.h
M  +3    -3    plugins/execute/projecttargetscombobox.h
M  +3    -3    plugins/executescript/executescriptplugin.h
M  +2    -2    plugins/executescript/iexecutescriptplugin.h
M  +2    -2    plugins/executescript/scriptappconfig.h
M  +2    -2    plugins/executescript/scriptappjob.h
M  +3    -3    plugins/externalscript/editexternalscript.h
M  +3    -3    plugins/externalscript/externalscriptdebug.h
M  +3    -3    plugins/externalscript/externalscriptitem.h
M  +3    -3    plugins/externalscript/externalscriptjob.h
M  +3    -3    plugins/externalscript/externalscriptplugin.h
M  +3    -3    plugins/externalscript/externalscriptview.h
M  +3    -3    plugins/filemanager/bookmarkhandler.h
M  +2    -2    plugins/filemanager/filemanager.h
M  +2    -2    plugins/filemanager/kdevfilemanagerplugin.h
M  +3    -3    plugins/filetemplates/classidentifierpage.h
M  +3    -3    plugins/filetemplates/classmemberspage.h
M  +3    -3    plugins/filetemplates/defaultcreateclasshelper.h
M  +3    -3    plugins/filetemplates/filetemplatesplugin.h
M  +3    -3    plugins/filetemplates/licensepage.h
M  +3    -3    plugins/filetemplates/outputpage.h
M  +3    -3    plugins/filetemplates/overridespage.h
M  +3    -3    plugins/filetemplates/templateclassassistant.h
M  +3    -3    plugins/filetemplates/templateoptionspage.h
M  +3    -3    plugins/filetemplates/templatepreview.h
M  +3    -3    plugins/filetemplates/templatepreviewtoolview.h
M  +3    -3    plugins/filetemplates/templateselectionpage.h
M  +3    -3    plugins/filetemplates/testcasespage.h
M  +3    -3    plugins/genericprojectmanager/genericmanager.h
M  +2    -2    plugins/genericprojectmanager/genericprojectmanagerpreferences.h
M  +2    -2    plugins/genericprojectmanager/test/reloadtest.h
M  +3    -3    plugins/git/gitclonejob.h
M  +3    -3    plugins/git/gitjob.h
M  +3    -3    plugins/git/gitmessagehighlighter.h
M  +2    -2    plugins/git/gitplugin.h
M  +3    -3    plugins/git/stashmanagerdialog.h
M  +2    -2    plugins/git/tests/initTest.h
M  +2    -2    plugins/grepview/grepdialog.h
M  +2    -2    plugins/grepview/grepfindthread.h
M  +2    -2    plugins/grepview/grepjob.h
M  +2    -2    plugins/grepview/grepoutputdelegate.h
M  +2    -2    plugins/grepview/grepoutputmodel.h
M  +3    -3    plugins/grepview/grepoutputview.h
M  +2    -2    plugins/grepview/greputil.h
M  +3    -3    plugins/grepview/tests/findreplacetest.h
M  +2    -2    plugins/konsole/kdevkonsoleview.h
M  +2    -2    plugins/konsole/kdevkonsoleviewplugin.h
M  +3    -3    plugins/openwith/iopenwith.h
M  +3    -3    plugins/openwith/openwithplugin.h
M  +2    -2    plugins/pastebin/pastebinplugin.h
M  +2    -2    plugins/patchreview/libdiff2/cvsdiffparser.h
M  +2    -2    plugins/patchreview/libdiff2/diff2export.h
M  +2    -2    plugins/patchreview/libdiff2/difference.h
M  +3    -3    plugins/patchreview/libdiff2/differencestringpair.h
M  +2    -2    plugins/patchreview/libdiff2/diffexport.h
M  +2    -2    plugins/patchreview/libdiff2/diffhunk.h
M  +2    -2    plugins/patchreview/libdiff2/diffmodel.h
M  +3    -3    plugins/patchreview/libdiff2/diffmodellist.h
M  +2    -2    plugins/patchreview/libdiff2/diffparser.h
M  +2    -2    plugins/patchreview/libdiff2/kompare.h
M  +2    -2    plugins/patchreview/libdiff2/komparemodellist.h
M  +2    -2    plugins/patchreview/libdiff2/kompareprocess.h
M  +3    -3    plugins/patchreview/libdiff2/levenshteintable.h
M  +3    -3    plugins/patchreview/libdiff2/marker.h
M  +2    -2    plugins/patchreview/libdiff2/parser.h
M  +2    -2    plugins/patchreview/libdiff2/parserbase.h
M  +2    -2    plugins/patchreview/libdiff2/perforceparser.h
M  +3    -3    plugins/patchreview/libdiff2/stringlistpair.h
M  +3    -3    plugins/patchreview/libdiff2/tests/interactivedifftest.h
M  +3    -3    plugins/patchreview/libdiff2/tests/levenshteintest.h
M  +3    -3    plugins/patchreview/localpatchsource.h
M  +2    -2    plugins/patchreview/patchhighlighter.h
M  +2    -2    plugins/patchreview/patchreview.h
M  +3    -3    plugins/patchreview/patchreviewtoolview.h
M  +2    -2    plugins/patchreview/settings/diffsettings.h
M  +2    -2    plugins/patchreview/settings/settingsbase.h
M  +3    -3    plugins/patchreview/standardpatchexport.h
M  +3    -3    plugins/problemreporter/problemhighlighter.h
M  +3    -3    plugins/problemreporter/problemmodel.h
M  +3    -3    plugins/problemreporter/problemreporterplugin.h
M  +2    -2    plugins/problemreporter/problemwidget.h
M  +3    -3    plugins/problemreporter/watcheddocumentset.h
M  +2    -2    plugins/projectmanagerview/projectbuildsetwidget.h
M  +3    -3    plugins/projectmanagerview/projectmanagerview.h
M  +2    -2    plugins/projectmanagerview/projectmanagerviewplugin.h
M  +3    -3    plugins/projectmanagerview/projectmodelitemdelegate.h
M  +3    -3    plugins/projectmanagerview/projectmodelsaver.h
M  +3    -3    plugins/projectmanagerview/projecttreeview.h
M  +3    -3    plugins/projectmanagerview/vcsoverlayproxymodel.h
M  +2    -2    plugins/quickopen/declarationlistquickopen.h
M  +3    -3    plugins/quickopen/documentationquickopenprovider.h
M  +3    -3    plugins/quickopen/expandingtree/expandingdelegate.h
M  +3    -3    plugins/quickopen/expandingtree/expandingtree.h
M  +2    -2    plugins/quickopen/expandingtree/expandingwidgetmodel.h
M  +2    -2    plugins/quickopen/quickopenmodel.h
M  +3    -3    plugins/quickopen/quickopenplugin.h
M  +3    -3    plugins/quickopen/tests/quickopenbench.h
M  +3    -3    plugins/quickopen/tests/quickopentest.h
M  +3    -3    plugins/quickopen/tests/quickopentestbase.h
M  +2    -2    plugins/reviewboard/reviewboardjobs.h
M  +2    -2    plugins/reviewboard/reviewboardplugin.h
M  +2    -2    plugins/reviewboard/reviewpatchdialog.h
M  +2    -2    plugins/snippet/legacy/editrepository.h
M  +2    -2    plugins/snippet/legacy/editsnippet.h
M  +3    -3    plugins/snippet/legacy/snippetcompletionitem.h
M  +2    -2    plugins/snippet/legacy/snippetcompletionmodel.h
M  +2    -2    plugins/snippet/legacy/snippetview.h
M  +2    -2    plugins/standardoutputview/outputwidget.h
M  +3    -3    plugins/standardoutputview/standardoutputview.h
M  +3    -3    plugins/standardoutputview/tests/standardoutputviewtest.h
M  +2    -2    plugins/standardoutputview/toolviewdata.h
M  +2    -2    plugins/subversion/kdevsvnplugin.h
M  +2    -2    plugins/subversion/svnaddjob.h
M  +2    -2    plugins/subversion/svnaddjob_p.h
M  +2    -2    plugins/subversion/svnblamejob.h
M  +2    -2    plugins/subversion/svnblamejob_p.h
M  +2    -2    plugins/subversion/svncatjob.h
M  +2    -2    plugins/subversion/svncatjob_p.h
M  +2    -2    plugins/subversion/svncatwidgets.h
M  +2    -2    plugins/subversion/svncheckoutjob.h
M  +2    -2    plugins/subversion/svncheckoutjob_p.h
M  +2    -2    plugins/subversion/svncheckoutmetadatawidget.h
M  +2    -2    plugins/subversion/svnclient.h
M  +2    -2    plugins/subversion/svncommitjob.h
M  +2    -2    plugins/subversion/svncommitjob_p.h
M  +2    -2    plugins/subversion/svncopyjob.h
M  +2    -2    plugins/subversion/svncopyjob_p.h
M  +2    -2    plugins/subversion/svncopywidgets.h
M  +2    -2    plugins/subversion/svndiffjob.h
M  +2    -2    plugins/subversion/svndiffjob_p.h
M  +2    -2    plugins/subversion/svnimportjob.h
M  +2    -2    plugins/subversion/svnimportjob_p.h
M  +2    -2    plugins/subversion/svnimportmetadatawidget.h
M  +2    -2    plugins/subversion/svninfojob.h
M  +2    -2    plugins/subversion/svninfojob_p.h
M  +2    -2    plugins/subversion/svninternaljobbase.h
M  +2    -2    plugins/subversion/svnjobbase.h
M  +3    -3    plugins/subversion/svnlocationwidget.h
M  +2    -2    plugins/subversion/svnlogjob.h
M  +2    -2    plugins/subversion/svnlogjob_p.h
M  +2    -2    plugins/subversion/svnmovejob.h
M  +2    -2    plugins/subversion/svnmovejob_p.h
M  +2    -2    plugins/subversion/svnmovewidgets.h
M  +2    -2    plugins/subversion/svnremovejob.h
M  +2    -2    plugins/subversion/svnremovejob_p.h
M  +2    -2    plugins/subversion/svnrevertjob.h
M  +2    -2    plugins/subversion/svnrevertjob_p.h
M  +2    -2    plugins/subversion/svnrevertwidgets.h
M  +2    -2    plugins/subversion/svnrevisionwidget.h
M  +2    -2    plugins/subversion/svnssldialog.h
M  +2    -2    plugins/subversion/svnstatusjob.h
M  +2    -2    plugins/subversion/svnstatusjob_p.h
M  +2    -2    plugins/subversion/svnstatuswidgets.h
M  +2    -2    plugins/subversion/svnupdatejob.h
M  +2    -2    plugins/subversion/svnupdatejob_p.h
M  +2    -2    plugins/subversion/svnupdatewidget.h
M  +3    -3    plugins/subversion/tests/svnimport.h
M  +3    -3    plugins/subversion/tests/svnrecursiveadd.h
M  +3    -3    plugins/switchtobuddy/switchtobuddyplugin.h
M  +3    -3    plugins/templatemanager/templateconfig.h
M  +3    -3    plugins/templatemanager/templatepage.h
M  +3    -3    plugins/testview/testview.h
M  +3    -3    plugins/testview/testviewdebug.h
M  +3    -3    plugins/testview/testviewplugin.h
M  +3    -3    plugins/vcschangesview/vcschangesview.h
M  +2    -2    plugins/vcschangesview/vcschangesviewplugin.h
M  +3    -3    project/abstractfilemanagerplugin.h
M  +2    -2    project/builderjob.h
M  +3    -3    project/filemanagerlistjob.h
M  +3    -3    project/helper.h
M  +3    -3    project/importprojectjob.h
M  +2    -2    project/interfaces/ibuildsystemmanager.h
M  +2    -2    project/interfaces/iprojectbuilder.h
M  +2    -2    project/interfaces/iprojectfilemanager.h
M  +2    -2    project/projectbuildsetmodel.h
M  +2    -2    project/projectconfigskeleton.h
M  +2    -2    project/projectexport.h
M  +2    -2    project/projectitemlineedit.h
M  +2    -2    project/projectkcmodule.h
M  +3    -3    project/projectmodel.h
M  +2    -2    project/projectproxymodel.h
M  +3    -3    project/projectutils.h
M  +3    -3    shell/assistantpopup.h
M  +2    -2    shell/completionsettings.h
M  +2    -2    shell/core.h
M  +2    -2    shell/core_p.h
M  +2    -2    shell/debugcontroller.h
M  +3    -3    shell/documentationcontroller.h
M  +2    -2    shell/documentcontroller.h
M  +2    -2    shell/kross/dvcsadaptors.h
M  +2    -2    shell/kross/krossbuildsystemmanager.h
M  +2    -2    shell/kross/krossdistributedversioncontrol.h
M  +2    -2    shell/kross/krossplugin.h
M  +2    -2    shell/kross/krosstoolviewfactory.h
M  +2    -2    shell/kross/krossvcsjob.h
M  +2    -2    shell/kross/projectitemadaptors.h
M  +2    -2    shell/kross/wrappers/krosscontext.h
M  +2    -2    shell/kross/wrappers/krosscontextmenuextension.h
M  +2    -2    shell/kross/wrappers/krossdeclaration.h
M  +2    -2    shell/kross/wrappers/krossduchainlock.h
M  +2    -2    shell/kross/wrappers/krossducontext.h
M  +2    -2    shell/kross/wrappers/krosseditorcontext.h
M  +2    -2    shell/kross/wrappers/krossibuildsystemmanager.h
M  +2    -2    shell/kross/wrappers/krossidentifier.h
M  +2    -2    shell/kross/wrappers/krossidocument.h
M  +2    -2    shell/kross/wrappers/krossilanguage.h
M  +2    -2    shell/kross/wrappers/krossiproblem.h
M  +2    -2    shell/kross/wrappers/krossiprojectbuilder.h
M  +2    -2    shell/kross/wrappers/krossiprojectfilemanager.h
M  +2    -2    shell/kross/wrappers/krossiuicontroller.h
M  +2    -2    shell/kross/wrappers/krossprojectmodel.h
M  +2    -2    shell/kross/wrappers/krossqtoolbar.h
M  +2    -2    shell/kross/wrappers/krosstopducontext.h
M  +2    -2    shell/kross/wrappers/krossuse.h
M  +2    -2    shell/kross/wrappers/krossvcslocation.h
M  +2    -2    shell/kross/wrappers/krossvcsrevision.h
M  +2    -2    shell/kross/xmltokross/duchainextractor.h
M  +2    -2    shell/kross/xmltokross/duchainreader.h
M  +2    -2    shell/kross/xmltokross/dummybsm.h
M  +2    -2    shell/kross/xmltokross/interfacecreator.h
M  +2    -2    shell/kross/xmltokross/krossimpl.h
M  +2    -2    shell/kross/xmltokross/krosswrapper.h
M  +2    -2    shell/kross/xmltokross/project.h
M  +2    -2    shell/language.h
M  +2    -2    shell/languagecontroller.h
M  +2    -2    shell/launchconfiguration.h
M  +2    -2    shell/launchconfigurationdialog.h
M  +3    -3    shell/loadedpluginsdialog.h
M  +2    -2    shell/mainwindow.h
M  +2    -2    shell/mainwindow_p.h
M  +2    -2    shell/openprojectdialog.h
M  +2    -2    shell/openprojectpage.h
M  +2    -2    shell/overlaywidget.h
M  +2    -2    shell/partdocument.h
M  +3    -3    shell/patchdocument.h
M  +2    -2    shell/plugincontroller.h
M  +2    -2    shell/progressdialog.h
M  +2    -2    shell/progressmanager.h
M  +2    -2    shell/progresswidget.h
M  +2    -2    shell/project.h
M  +2    -2    shell/projectcontroller.h
M  +2    -2    shell/projectinfopage.h
M  +3    -3    shell/projectsourcepage.h
M  +2    -2    shell/runcontroller.h
M  +2    -2    shell/savedialog.h
M  +3    -3    shell/selectioncontroller.h
M  +2    -2    shell/session.h
M  +2    -2    shell/sessioncontroller.h
M  +2    -2    shell/sessiondialog.h
M  +2    -2    shell/settings/bgpreferences.h
M  +2    -2    shell/settings/ccpreferences.h
M  +3    -3    shell/settings/editstyledialog.h
M  +2    -2    shell/settings/environmentgroupmodel.h
M  +2    -2    shell/settings/environmentpreferences.h
M  +2    -2    shell/settings/environmentwidget.h
M  +2    -2    shell/settings/pluginpreferences.h
M  +2    -2    shell/settings/projectpreferences.h
M  +2    -2    shell/settings/sessionconfigskeleton.h
M  +3    -3    shell/settings/sourceformattersettings.h
M  +2    -2    shell/settings/uipreferences.h
M  +2    -2    shell/shellexport.h
M  +2    -2    shell/shellextension.h
M  +3    -3    shell/sourceformattercontroller.h
M  +3    -3    shell/statusbar.h
M  +3    -3    shell/testcontroller.h
M  +3    -3    shell/tests/documentcontrollertest.h
M  +2    -2    shell/tests/shellbuddytest.h
M  +2    -2    shell/tests/shelldocumentoperationtest.h
M  +3    -3    shell/tests/testcontrollertest.h
M  +3    -3    shell/tests/uicontrollertest.h
M  +2    -2    shell/textdocument.h
M  +2    -2    shell/uicontroller.h
M  +3    -3    shell/workingsetcontroller.h
M  +3    -3    shell/workingsets/closedworkingsetswidget.h
M  +3    -3    shell/workingsets/workingset.h
M  +3    -3    shell/workingsets/workingsetfilelabel.h
M  +3    -3    shell/workingsets/workingsethelpers.h
M  +3    -3    shell/workingsets/workingsettoolbutton.h
M  +3    -3    shell/workingsets/workingsettooltipwidget.h
M  +3    -3    shell/workingsets/workingsetwidget.h
M  +2    -2    sublime/aggregatemodel.h
M  +2    -2    sublime/area.h
M  +2    -2    sublime/areaindex.h
M  +2    -2    sublime/areawalkers.h
M  +2    -2    sublime/blur.h
M  +2    -2    sublime/container.h
M  +2    -2    sublime/controller.h
M  +2    -2    sublime/document.h
M  +2    -2    sublime/examples/example1main.h
M  +2    -2    sublime/examples/example2main.h
M  +3    -3    sublime/holdupdates.h
M  +2    -2    sublime/ideallayout.h
M  +2    -2    sublime/mainwindow.h
M  +2    -2    sublime/mainwindow_p.h
M  +2    -2    sublime/mainwindowoperator.h
M  +2    -2    sublime/sublimedefs.h
M  +2    -2    sublime/sublimeexport.h
M  +2    -2    sublime/tests/aggregatemodeltest.h
M  +2    -2    sublime/tests/areaoperationtest.h
M  +2    -2    sublime/tests/areaprinter.h
M  +2    -2    sublime/tests/areawalkertest.h
M  +2    -2    sublime/tests/controllertest.h
M  +2    -2    sublime/tests/documenttest.h
M  +2    -2    sublime/tests/toolviewtoolbartest.h
M  +2    -2    sublime/tests/viewactivationtest.h
M  +2    -2    sublime/tests/viewtest.h
M  +2    -2    sublime/tooldocument.h
M  +2    -2    sublime/urldocument.h
M  +2    -2    sublime/view.h
M  +3    -3    template/filters/kdevfilters.h
M  +2    -2    tests/autotestshell.h
M  +3    -3    tests/json/declarationvalidator.h
M  +3    -3    tests/json/delayedoutput.h
M  +3    -3    tests/json/jsondeclarationtests.h
M  +3    -3    tests/json/jsonducontexttests.h
M  +3    -3    tests/json/jsontesthelpers.h
M  +3    -3    tests/json/jsontypetests.h
M  +2    -2    tests/json/kdevplatformjsontestsexport.h
M  +3    -3    tests/json/testsuite.h
M  +2    -2    tests/kdevplatformtestsexport.h
M  +2    -2    tests/kdevsignalspy.h
M  +2    -2    tests/modeltest.h
M  +2    -2    tests/testcore.h
M  +3    -3    tests/testhelpers.h
M  +3    -3    tests/testlanguagecontroller.h
M  +3    -3    tests/testplugincontroller.h
M  +2    -2    util/activetooltip.h
M  +2    -2    util/commandexecutor.h
M  +2    -2    util/convenientfreelist.h
M  +2    -2    util/duchainify/main.h
M  +3    -3    util/environmentconfigurebutton.h
M  +2    -2    util/environmentgrouplist.h
M  +2    -2    util/environmentselectionwidget.h
M  +2    -2    util/executecompositejob.h
M  +3    -3    util/fileutils.h
M  +3    -3    util/focusedtreeview.h
M  +3    -3    util/formattinghelpers.h
M  +3    -3    util/kdevstringhandler.h
M  +3    -3    util/kdevvarlengtharray.h
M  +2    -2    util/ksharedobject.h
M  +3    -3    util/multilevellistview.h
M  +3    -3    util/projecttestjob.h
M  +2    -2    util/pushvalue.h
M  +3    -3    util/richtextpushbutton.h
M  +3    -3    util/richtexttoolbutton.h
M  +2    -2    util/sequentiallyrunjobs.h
M  +3    -3    util/spinlock.h
M  +2    -2    util/ssh_client/main.h
M  +2    -2    util/utilexport.h
M  +2    -2    vcs/dvcs/dvcsevent.h
M  +2    -2    vcs/dvcs/dvcsjob.h
M  +2    -2    vcs/dvcs/dvcsplugin.h
M  +2    -2    vcs/dvcs/tests/dvcsjobTest.h
M  +2    -2    vcs/dvcs/ui/branchmanager.h
M  +2    -2    vcs/dvcs/ui/importmetadatawidget.h
M  +2    -2    vcs/dvcs/ui/revhistory/commitView.h
M  +2    -2    vcs/dvcs/ui/revhistory/commitlogmodel.h
M  +2    -2    vcs/interfaces/ibasicversioncontrol.h
M  +2    -2    vcs/interfaces/ibranchingversioncontrol.h
M  +2    -2    vcs/interfaces/ibrowsableversioncontrol.h
M  +2    -2    vcs/interfaces/icentralizedversioncontrol.h
M  +2    -2    vcs/interfaces/idistributedversioncontrol.h
M  +2    -2    vcs/interfaces/irepositoryversioncontrol.h
M  +3    -3    vcs/models/brancheslistmodel.h
M  +3    -3    vcs/models/projectchangesmodel.h
M  +3    -3    vcs/models/tests/modelstest.h
M  +2    -2    vcs/models/vcsannotationmodel.h
M  +2    -2    vcs/models/vcseventmodel.h
M  +3    -3    vcs/models/vcsfilechangesmodel.h
M  +2    -2    vcs/models/vcsitemeventmodel.h
M  +2    -2    vcs/tests/vcsBlackBoxTest.h
M  +2    -2    vcs/vcsannotation.h
M  +2    -2    vcs/vcsdiff.h
M  +2    -2    vcs/vcsevent.h
M  +3    -3    vcs/vcsexport.h
M  +2    -2    vcs/vcsjob.h
M  +2    -2    vcs/vcslocation.h
M  +2    -2    vcs/vcspluginhelper.h
M  +2    -2    vcs/vcsrevision.h
M  +2    -2    vcs/vcsstatusinfo.h
M  +2    -2    vcs/widgets/flexibleaction.h
M  +3    -3    vcs/widgets/standardvcslocationwidget.h
M  +2    -2    vcs/widgets/vcsannotationwidget.h
M  +2    -2    vcs/widgets/vcscommitdialog.h
M  +3    -3    vcs/widgets/vcsdiffpatchsources.h
M  +2    -2    vcs/widgets/vcsdiffwidget.h
M  +2    -2    vcs/widgets/vcseventwidget.h
M  +2    -2    vcs/widgets/vcsimportmetadatawidget.h
M  +2    -2    vcs/widgets/vcslocationwidget.h

http://commits.kde.org/kdevplatform/156fb9e5c615346ff9ecee3632c8ff8314825a79