Bug 281405 - [testcase] incorrect baseline for checkbox and radio buttons
Summary: [testcase] incorrect baseline for checkbox and radio buttons
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml forms (show other bugs)
Version: 4.7.0
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-05 15:47 UTC by Andrea Iacovitti
Modified: 2011-09-17 09:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 4.7.2


Attachments
testcase (1.34 KB, text/html)
2011-09-05 15:47 UTC, Andrea Iacovitti
Details
possible patch (1.19 KB, patch)
2011-09-05 15:49 UTC, Andrea Iacovitti
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Iacovitti 2011-09-05 15:47:09 UTC
Created attachment 63405 [details]
testcase

Version:           4.7.0
OS:                Linux

Baseline position for checkbox and radio input is not correctly calculated

Reproducible: Always

Steps to Reproduce:
Load the attached testcase.
(...or go to http://pastebin.kde.org/ and look the position of checkbox labeled "Mark as private")

Actual Results:  
CheckBox and Radio buttons are not aligned with other widgets text content.

Expected Results:  
CheckBox and Radio buttons must be aligned with other widgets text content.
Comment 1 Andrea Iacovitti 2011-09-05 15:49:35 UTC
Created attachment 63407 [details]
possible patch
Comment 2 Andrea Iacovitti 2011-09-14 13:03:06 UTC
The previous patch breaks regression tests
Comment 3 Andrea Iacovitti 2011-09-17 09:16:18 UTC
Git commit 4b41e546a12ae4ccf7930f78ed09fe7a6ea745d0 by Andrea Iacovitti.
Committed on 17/09/2011 at 11:13.
Pushed by aiacovitti into branch 'KDE/4.7'.

Fix baseline position for checkboxes and radio buttons.
BUG: 281405
FIXED-IN: 4.7.2

M  +4    -1    khtml/rendering/render_form.cpp

http://commits.kde.org/kdelibs/4b41e546a12ae4ccf7930f78ed09fe7a6ea745d0