Created attachment 63193 [details] error message Version: 2.4.0 (using KDE 4.7.0) OS: Linux krusader deletes! zip archive when user cut (ctrl-x) this archive and insert (ctrl-v) it to its own content Reproducible: Always Steps to Reproduce: 1) create some zip archive, for example test.zip with content a.txt and b.txt file 2) hit ctrl-x on this archive test.zip in krusader 3) enter to this archive test.zip in krusader (so you can see content a.txt and b.txt) 4) hit ctrl-v to insert it to itself -> got error "could not start process" and this archive is DELETED !!! (see screenshot) (i know you asking why user would insert this archive to its content ?, but i think only by accident like myself.. whole my archive was deleted...) this is huge bug and it need to be resolved asap, thanks guys please contact me if you will need any kind of additional description, sobik2@gmail.com Actual Results: archive is deleted Expected Results: krusader shouldnt delete this archive !!! OS: Linux (i686) release 2.6.38-11-generic Compiler: gcc sobi@sobi-laptop:~$ uname -a Linux sobi-laptop 2.6.38-11-generic #48-Ubuntu SMP Fri Jul 29 19:05:14 UTC 2011 i686 i686 i386 GNU/Linux sobi@sobi-laptop:~$ krusader --version Qt: 4.7.2 KDE Development Platform: 4.7.00 (4.7.0) Krusader: 2.4.0-beta1 "Migration"
This bug is caused by the krarc kioslave. I don't have the time to fix krarc, so my "fix" is to disablee krarc for now. see commit dc1b210948c9e92023ceca36383500b635677636
IMHO, disabling the entire krarc is not an acceptable solution, and completely out of proportion with the "bug" it is fixing (trying to move an archive into itself, no wonder this doesn't work!).
(The archive getting deleted is exactly what I'd expect to happen in this case. You move the archive into itself, which is now an unlinked inode, so bye bye archive. Of course, this isn't actually how it happens in practice, but I'm not surprised by the archive getting deleted in this situation at all.)
See https://bugs.kde.org/show_bug.cgi?id=294542 for more comments on this.
I re-enabled KrArc (see comment 4 for https://bugs.kde.org/show_bug.cgi?id=294542), therefore reintroducing this bug. A proper fix for will require some code-cleanup which won't happen until after the 2.4 release.
Git commit 03ee68ab49c68bf1e1ca7b01fe08799462d510c4 by Jan Lepper. Committed on 07/09/2012 at 16:44. Pushed by janlepper into branch 'master'. ADDED: option: Archives > krarc > Enable Write Support CHANGED: krarc write support is disabled by default show a warning notice in Konfigurator about the implications of krarc write support M +2 -0 ChangeLog M +27 -0 krArc/krarc.cpp M +1 -0 krArc/krarc.h M +25 -2 krusader/Konfigurator/kgarchives.cpp M +0 -6 krusader/Panel/panelfunc.cpp M +2 -0 krusader/krslots.cpp http://commits.kde.org/krusader/03ee68ab49c68bf1e1ca7b01fe08799462d510c4