Bug 280852 - after using "undo" in klines balls have disappear and moves have not correctly computed
Summary: after using "undo" in klines balls have disappear and moves have not correctl...
Status: RESOLVED FIXED
Alias: None
Product: klines
Classification: Applications
Component: general (show other bugs)
Version: 1.5
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dmitry Suzdalev
URL:
Keywords:
: 289796 296014 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-08-26 19:57 UTC by and
Modified: 2012-03-14 23:52 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.8.2


Attachments
Start posission (269.91 KB, image/png)
2012-03-11 18:26 UTC, Sergey
Details
move ball (279.61 KB, image/png)
2012-03-11 18:26 UTC, Sergey
Details
undo (must be start posission klines1.png) (266.52 KB, image/png)
2012-03-11 18:27 UTC, Sergey
Details

Note You need to log in before you can comment on or make changes to this bug.
Description and 2011-08-26 19:57:23 UTC
Version:           1.5 (using KDE 4.7.0) 
OS:                Linux

After using "undo" button balls dissapeared and moves have not correctly computed.

Reproducible: Always

Steps to Reproduce:
Move any ball to any position and use "undo" button

Actual Results:  
Balls have disappear, any further moves computed incorrectly

Expected Results:  
Balls moved to previous position
Comment 1 Sergey 2011-11-15 06:06:23 UTC
Any progress resolving the bug?
klines 4.7.2 the same problem.
Comment 2 Sergey 2011-11-29 08:14:30 UTC
Any progress resolving the bug?
Comment 3 Albert Astals Cid 2011-12-20 22:03:23 UTC
SVN commit 1269603 by aacid:

Give the item a size, otherwise it's not seen by the user and thinks it is not there

If you ask me this call should be in the BallItem constructor, but nobody asked me :D

BUGS: 280852
FIXED-IN: 4.8.0


 M  +1 -0      scene.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1269603
Comment 4 Albert Astals Cid 2011-12-26 18:54:15 UTC
*** Bug 289796 has been marked as a duplicate of this bug. ***
Comment 5 Sergey 2012-03-11 16:32:10 UTC
4.8.1 HAS THE SAME BUG!!!!
When it'll fix?
Never?
Comment 6 Frederik Schwarzer 2012-03-11 17:36:37 UTC
What exactly is still broken?
I can undo and the item remains visible.
Comment 7 Sergey 2012-03-11 18:04:41 UTC
Choose ball, move it, undo and ball disapear instead of go back.
Ball return on previuos posission but it became invisible.
Comment 8 Sergey 2012-03-11 18:26:10 UTC
Created attachment 69505 [details]
Start posission
Comment 9 Sergey 2012-03-11 18:26:50 UTC
Created attachment 69506 [details]
move ball
Comment 10 Sergey 2012-03-11 18:27:55 UTC
Created attachment 69507 [details]
undo (must be start posission klines1.png)
Comment 11 Frederik Schwarzer 2012-03-11 21:52:55 UTC
Can you please check your application version under "Help->About Kolor Lines"?
Comment 12 Sergey 2012-03-12 06:51:56 UTC
I'm sure that version is 4.8.1. I just upgrade Ubuntu to 12.04
I can check today later.
Comment 13 Sergey 2012-03-12 16:29:59 UTC
klines version 1.5
KDE 4.8.1
Comment 14 Sergey 2012-03-12 18:39:54 UTC
--- kdegames-4.8.1/klines/scene.cpp     2011-08-07 19:48:13.000000000 +0400
+++ scene.cpp       2011-12-21 22:32:18.000000000 +0400
@@ -641,6 +641,7 @@
                 item->setColor(col);
                 item->setPos( fieldToPix( FieldPos(x,y) ) );
                 item->show();
+                item->setRenderSize(KLinesRenderer::cellExtent());
                 m_field[x][y] = item;
             }
         }
Comment 15 Albert Astals Cid 2012-03-12 22:44:30 UTC
Sergey, learn to be polite, shouting won't help.
Comment 16 Albert Astals Cid 2012-03-12 22:56:14 UTC
SVN commit 1285251 by aacid:

Dirk branched 2 hours before my commit and thus the fix was only available in the KDE 4.9 branch
FIXED-IN: 4.8.2


 M  +1 -0      scene.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1285251
Comment 17 Sergey 2012-03-13 07:02:24 UTC
Albert, I ask about this bug more than half year.
I think that nobody read this page.
What we need is just include one missing line to source.
To use this game I have to recompile sources since version 4.7.3
How long it takes to commit one line to source?
Comment 18 Albert Astals Cid 2012-03-13 09:13:46 UTC
So you thought noone was reading and because of that decided TO SHOUT?

Next time you think noone is reading i suggest you to find alternate ways of communication like the kdegames mailing list or the kde games irc channel or the kde forum :-)
Comment 19 Sergey 2012-03-13 19:10:09 UTC
I thnk this is not correct place for such discussions.
If you have other advices you can write directly to my e-mail.
Comment 20 Christoph Feck 2012-03-14 23:52:34 UTC
*** Bug 296014 has been marked as a duplicate of this bug. ***