Bug 280627 - Rekonq do not quit when closing window
Summary: Rekonq do not quit when closing window
Status: RESOLVED FIXED
Alias: None
Product: rekonq
Classification: Unmaintained
Component: general (show other bugs)
Version: latest git snapshot
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 0.10
Assignee: Andrea Diamantini
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-23 08:06 UTC by Cédric Bellegarde
Modified: 2012-09-18 19:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Cédric Bellegarde 2011-08-23 08:06:34 UTC 
Version:           latest git snapshot (using KDE 4.7.0) 
OS:                Linux

Sometimes (2, 3 time a day), rekonq start telling me it has crashed in last session.

If i look at process, i can see that in fact, rekonq never quit, processus keep running.

Reproducible: Sometimes

Steps to Reproduce:
Can't find a way (random)


Expected Results:  
rekonq should quit
Comment 1 Cédric Bellegarde 2011-08-23 08:08:52 UTC 
http://adishatz.1s.fr/~gnumdk/rekonq.ogv
Comment 3 Cédric Bellegarde 2011-12-21 08:56:11 UTC 
Since you remove my patch, bug is here again...

I switch to 0.8.1 and rekonq do not quit again :-/
Comment 5 Cédric Bellegarde 2011-12-21 09:03:03 UTC 
Here what make me think Qtwebkit create window with no Qt::WA_QuitOnClose flag

No rekonq window available, rekonq process runnning and if i run xwininfo, it find a rekonq window:

[gnumdk@arch ~]$ xwininfo -name rekonq

xwininfo: Window id: 0x5600002 "rekonq"

  Absolute upper-left X:  0
  Absolute upper-left Y:  0
  Relative upper-left X:  0
  Relative upper-left Y:  0
  Width: 840
  Height: 420
  Depth: 24
  Visual: 0x21
  Visual Class: TrueColor
  Border width: 0
  Class: InputOutput
  Colormap: 0x20 (installed)
  Bit Gravity State: NorthWestGravity
  Window Gravity State: NorthWestGravity
  Backing Store State: NotUseful
  Save Under State: no
  Map State: IsUnMapped
  Override Redirect State: no
  Corners:  +0+0  -2520+0  -2520-630  +0-630
  -geometry 840x420+0+0
Comment 6 Andrea Diamantini 2011-12-22 22:56:04 UTC 
(In reply to comment #5)
> Here what make me think Qtwebkit create window with no Qt::WA_QuitOnClose flag
> 
> No rekonq window available, rekonq process runnning and if i run xwininfo, it
> find a rekonq window:
> 
> [gnumdk@arch ~]$ xwininfo -name rekonq
> 
> xwininfo: Window id: 0x5600002 "rekonq"
> 
>   Absolute upper-left X:  0
>   Absolute upper-left Y:  0
>   Relative upper-left X:  0
>   Relative upper-left Y:  0
>   Width: 840
>   Height: 420
>   Depth: 24
>   Visual: 0x21
>   Visual Class: TrueColor
>   Border width: 0
>   Class: InputOutput
>   Colormap: 0x20 (installed)
>   Bit Gravity State: NorthWestGravity
>   Window Gravity State: NorthWestGravity
>   Backing Store State: NotUseful
>   Save Under State: no
>   Map State: IsUnMapped
>   Override Redirect State: no
>   Corners:  +0+0  -2520+0  -2520-630  +0-630
>   -geometry 840x420+0+0

QtWebKit is not dark magic, it's opensource. You can just check its code to prove you are wrong. Or run a simple test like this:

#include <QApplication>
#include <QWebView>
#include <QDebug>

int main(int argc, char**argv)
{
    QApplication app(argc,argv);
    QWebView widg;
    qDebug() << widg.testAttribute(Qt::WA_QuitOnClose);
    widg.show();
    return app.exec();
}

And see that qDebug returns true. Your solution simply doesn't work in general: in example, what if you close last window while you are downloading a file? Who takes care of it?

I'd like to know more about your bug as it never happened here. Do you have some particular settings? Does this ever happen? How can I reproduce it?
Comment 7 Cédric Bellegarde 2012-01-23 08:18:24 UTC 
It happen on Ubuntu and ArchLinux, don't know how to reproduce it...

Will try to see if some settings in rekonq affect this bug...
Comment 8 Cédric Bellegarde 2012-02-13 11:32:08 UTC 
Ok, found how to reproduce...

Disable flash plugin and go here:
http://www.omgubuntu.co.uk/2012/02/gnomes-new-lock-screen-design-goes-online/

Play gdm "html5 video" and then close rekonq, it doesn't quit...

Hope it will work for you :-/
Comment 9 Andrea Diamantini 2012-02-13 23:13:22 UTC 
It works for me. Disabled plugins, visited site, played video, closed rekonq. It quits..
Comment 10 Thomas Pfeiffer 2012-06-08 18:20:12 UTC 
I often experience this bug as well. It seems to be more likely to happen if I had rekonq open for a while with many visited websites especially with resource-heavy flash content.
Comment 11 Andrea Diamantini 2012-06-09 22:35:51 UTC 
Are you downloading something?
Comment 12 Thomas Pfeiffer 2012-06-09 23:01:38 UTC 
No, I am not. Unless Rekonq falsely thinks I am...
Comment 13 Andrea Diamantini 2012-09-18 19:35:57 UTC 
Reapplied a patch similar to the one Cedric proposed. This is fixed in the 1.x series. Please, reopen this (again) if not there.